Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove InternalValidate patch to plugin-sdk #1928

Closed
VenelinMartinov opened this issue May 6, 2024 · 1 comment
Closed

Remove InternalValidate patch to plugin-sdk #1928

VenelinMartinov opened this issue May 6, 2024 · 1 comment
Labels
kind/engineering Work that is not visible to an external user resolution/by-design This issue won't be fixed because the functionality is working as designed

Comments

@VenelinMartinov
Copy link
Contributor

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

After #1854 the patch we added before on the plugin-sdk is no longer necessary: pulumi/terraform-plugin-sdk#37

We should be able to remove it freely, there are also tests covering the behaviour.

Note that due to our system with replace, this inevitable causes some user pain, so we might want to package the change with other changes.

Affected area/feature

@VenelinMartinov VenelinMartinov added the kind/engineering Work that is not visible to an external user label May 6, 2024
@VenelinMartinov VenelinMartinov added the resolution/by-design This issue won't be fixed because the functionality is working as designed label Jun 3, 2024
@VenelinMartinov
Copy link
Contributor Author

This is wrong - the patch still offers a performance optimisation for large providers - the only unnecessary thing is the global variable, which doesn't really hurt either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user resolution/by-design This issue won't be fixed because the functionality is working as designed
Projects
None yet
Development

No branches or pull requests

1 participant