Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor extractInputs to remove rawNames #1830

Closed
iwahbe opened this issue Apr 2, 2024 · 1 comment · Fixed by #1851
Closed

Refactor extractInputs to remove rawNames #1830

iwahbe opened this issue Apr 2, 2024 · 1 comment · Fixed by #1851
Assignees
@iwahbe
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@iwahbe
Copy link
Member

iwahbe commented Apr 2, 2024 •
edited
Loading

rawNames makes the implementation of extractInputs confusing and is incorrect. We should clean up the area and narrow down the desired behavior of rawNames, document the desired behavior and put it under test.

I know recent PRs have changed behavior here for Read and tests did not flag the change.
@iwahbe iwahbe self-assigned this Apr 2, 2024
@iwahbe iwahbe changed the title resource inputs refactors Refactor extractInputs to remove rawNames Apr 2, 2024
@iwahbe iwahbe mentioned this issue Apr 10, 2024
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Apr 13, 2024
@pulumi-bot pulumi-bot reopened this Apr 13, 2024
@pulumi-bot
Copy link
Contributor

Cannot close issue:

  • does not have required labels: kind/

Please fix these problems and try again.

@iwahbe iwahbe added the kind/engineering Work that is not visible to an external user label Apr 13, 2024
@iwahbe iwahbe closed this as completed Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iwahbe iwahbe

Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove rawNames from makeObjectTerraformInputs pulumi/pulumi-terraform-bridge
2 participants
@iwahbe @pulumi-bot