Do not run upgrade check for this provider #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
mjeffryes
approved these changes
Nov 5, 2024
Makefile
Outdated
| @@ -180,7 +180,6 @@ bin/pulumi-java-gen: .pulumi-java-gen.version | |||
| # - Run make ci-mgmt to apply the change locally. | |||
| # | |||
| ci-mgmt: .ci-mgmt.yaml | |||
| find .github/workflows/*.yml -type f ! -name "$(PACK)*.yml" -delete | |||
There was a problem hiding this comment.
I'm surprised that this changes with the checkUpstreamUpgrade flag change
There was a problem hiding this comment.
This is an unrelated change from bumping ci-mgmt to latest. Since ci-mgmt isn't versioned, each time a change is made to .ci-mgmt.yaml and then applied with make ci-mgmt the latest version of ci-mgmt is pulled.
There was a problem hiding this comment.
It was a recent change in ci-mgmt that had not done the nightly percolation. It's a legitimate change; I verified.
guineveresaenger
force-pushed
the
guin/skip-upstream-upgrade
branch
from
7509f22 to
3e012ee
Compare
guineveresaenger
added
the
impact/no-changelog-required
mikhailshilkov
added
impact/no-changelog-required
|
This PR has been shipped in release v0.3.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the upstream provider is pre-stable release, we run upgrades manually.
Fixes #200.