-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fixes #97 with a patch while we resolve the underlying bridge issue. I've set the name property on the vlan_names to be non-computed - this works around the bridge issue. I believe this patch is perfectly safe to take - name is not really computed - the resource does not actually work if not specified.
- Loading branch information
1 parent
2e72cb2
commit cac4181
Showing
5 changed files
with
24 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,4 +32,7 @@ sdk/java/gradlew.bat | |
|
||
sdk/python/venv | ||
|
||
sdk/dotnet/logo.png | ||
sdk/dotnet/logo.png | ||
|
||
go.work | ||
go.work.sum |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | ||
From: Venelin <[email protected]> | ||
Date: Fri, 12 Jul 2024 17:27:42 +0100 | ||
Subject: [PATCH] patch vlan profiles to be non-computed | ||
|
||
|
||
diff --git a/internal/provider/resource_meraki_networks_vlan_profiles.go b/internal/provider/resource_meraki_networks_vlan_profiles.go | ||
index 80dbca9..3cb4b2e 100644 | ||
--- a/internal/provider/resource_meraki_networks_vlan_profiles.go | ||
+++ b/internal/provider/resource_meraki_networks_vlan_profiles.go | ||
@@ -152,7 +152,6 @@ func (r *NetworksVLANProfilesResource) Schema(_ context.Context, _ resource.Sche | ||
}, | ||
"name": schema.StringAttribute{ | ||
MarkdownDescription: `Name of the VLAN, string length must be from 1 to 32 characters`, | ||
- Computed: true, | ||
Optional: true, | ||
PlanModifiers: []planmodifier.String{ | ||
stringplanmodifier.UseStateForUnknown(), |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18327,7 +18327,6 @@ | |
"nodejs": { | ||
"requiredOutputs": [ | ||
"adaptivePolicyGroup", | ||
"name", | ||
"vlanId" | ||
] | ||
} | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.