Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow helm charts to disable autonaming #1644

Closed
Tracked by #2847
jaxxstorm opened this issue Jul 1, 2021 · 5 comments
Closed
Tracked by #2847

Allow helm charts to disable autonaming #1644

jaxxstorm opened this issue Jul 1, 2021 · 5 comments
Assignees
Labels
area/helm kind/enhancement Improvements or new features mro2 Monica's list of 2st tier overlay related issues resolution/fixed This issue was fixed

Comments

@jaxxstorm
Copy link
Contributor

Many Pulumi users do not want to use autonaming on their resources for a variety of good reasons. Our current helm implementation only allows this if the chart has a fullNameOverride value.

We don't expose a name property like we do with many other resources, which makes this exceptionally difficult. You can sort of work around it with transformations, but it's not very user friendly.

We should implement a name property for all resources in the Component to allow users to have flexibility over their naming

@jaxxstorm jaxxstorm added kind/enhancement Improvements or new features area/helm labels Jul 1, 2021
@headconnect
Copy link

The current behavior is that helm charts take their name from the pulumi name - which is usually more verbose than the desired result. This can lead to more complex deployments over time - for instance where helm charts are deployed to multiple clusters (requiring unique pulumi names so as to avoid URN conflicts) - and ingresses are deployed separately (which would require special logic to ensure the selectors go to the specific instance). Essentially, instead of having two clusters with "prometheus", you get two clusters with "cluster1-prometheus" and "cluster2-prometheus" even though it's fairly apparent which cluster is which.

Decoupling the chart name from the pulumi name would be highly beneficial (though please ensure the pulumi name is what's reflected in the stack URNs once the chart is expanded)

@ghost
Copy link

ghost commented Jul 28, 2021

You can sort of work around it with transformations, but it's not very user friendly.

Any chance you can give an example of this? I'd be happy if my nginx ingress controller was not named nginx-ingress-ingress-nginx-controller (which is made worse by the fact that my applications need to refer to it as http://nginx-ingress-ingress-nginx-controller.nginx since it is in the nginx namespace)

@mnlumi mnlumi added the mro2 Monica's list of 2st tier overlay related issues label Mar 28, 2023
@EronWright
Copy link
Contributor

I believe the ask here is to support --release-name parameter on helm template, which defaults to the Chart component name.

@EronWright

This comment was marked as off-topic.

@EronWright EronWright self-assigned this May 14, 2024
@EronWright EronWright added the resolution/fixed This issue was fixed label May 14, 2024
@EronWright
Copy link
Contributor

This is fixed in Chart v4 since it provides a name input to set the release name. I would still recommend that people set the fullNameOverride in preference to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm kind/enhancement Improvements or new features mro2 Monica's list of 2st tier overlay related issues resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

4 participants