Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm GetResource id not consistent between SDKs #1354

Open
Tracked by #2847
lblackstone opened this issue Oct 12, 2020 · 0 comments
Open
Tracked by #2847

Helm GetResource id not consistent between SDKs #1354

lblackstone opened this issue Oct 12, 2020 · 0 comments
Labels
area/helm kind/bug Some behavior is incorrect or out of spec mro1 Monica's list of 1st tier overlay related issues

Comments

@lblackstone
Copy link
Member

Problem description

It looks like the expected id field for the GetResource method on Helm charts is not consistent between all SDKs. For example, Go is expecting the fully qualified GVK (networking.k8s.io/v1beta1/Ingress), while TypeScript is expecting the simplified GVK (networking/v1beta1/Ingress).

Since we don't want to make a backward incompatible change, we should probably support either format going forward.
@lblackstone lblackstone added kind/bug Some behavior is incorrect or out of spec area/helm labels Oct 12, 2020
@lblackstone lblackstone self-assigned this Oct 12, 2020
@mnlumi mnlumi added the mro1 Monica's list of 1st tier overlay related issues label Mar 28, 2023
@lblackstone lblackstone removed their assignment Jul 14, 2023
@EronWright EronWright mentioned this issue Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/helm kind/bug Some behavior is incorrect or out of spec mro1 Monica's list of 1st tier overlay related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lblackstone @mnlumi