Cannot override Helm values.yaml file reference

[Freakazoid182]

Problem description

Some charts provide several values.yaml files. For instance in the bitnami repository you often see a separate file for production:
https://github.com/bitnami/charts/blob/master/bitnami/prometheus-operator/values-production.yaml

The default values for charts is always taken from values.yaml which is hardcoded.
Currently there is no way to reference another file to set default values as far as I can see.
Is it intentional that the file reference is hardcoded? It seems useful to allow selecting another one as the default values.yaml.

dotnet:

pulumi-kubernetes/sdk/dotnet/Helm/ChartBase.cs

Line 90 in aa85b8b

defaultValues = Path.Join(chartDirectoryName, fetchedChartName, "values.yaml");

nodejs:

pulumi-kubernetes/sdk/nodejs/helm/v2/helm.ts

Line 185 in 2bf17bb

nodepath.join(chartDir.name, fetchedChartName, "values.yaml")

pulumi-kubernetes/sdk/nodejs/helm/v3/helm.ts

Line 185 in 2bf17bb

nodepath.join(chartDir.name, fetchedChartName, "values.yaml")

go

pulumi-kubernetes/sdk/go/kubernetes/helm/v2/chart.go

Line 316 in 5971a9e

defaultVals := filepath.Join(chart, "values.yaml")

pulumi-kubernetes/sdk/go/kubernetes/helm/v3/chart.go

Line 316 in 5971a9e

defaultVals := filepath.Join(chart, "values.yaml")

python

pulumi-kubernetes/sdk/python/pulumi_kubernetes/helm/v2/helm.py

Line 536 in 52a8169

default_values = os.path.join(chart, 'values.yaml')

pulumi-kubernetes/sdk/python/pulumi_kubernetes/helm/v3/helm.py

Line 536 in 52a8169

default_values = os.path.join(chart, 'values.yaml')

Suggestions for a fix

I would suggest we make values.yaml overridable through BaseChart(Arg/Opts) (depending on language).

If that's ok, what would be the preferred approach here? I'm happy to provide a PR.

[lblackstone]

This is also somewhat related to #659

[wuqunfei]

@leezen , do you have some update of this requirement? because there are so many helm values.yaml file in existing legancy environment. It is quite hard to rewrite into code. It is a really useful function to imgrate existing helm system smoothly.

[squaremo]

IIUC, the Helm spec has it that the values.yaml file provides defaults -- that's why it will be hard-coded in the library.

Vendors sometimes include values-xyz.yaml files as examples of non-default configuration you might want to use, but they have no status other than providing an example. The way you'd use an example like that would be to download the file from the repo, or copy its contents into a local file, then refer to it when you invoke Helm:

helm install [...] --values ./values-production.yaml

Bitnami removed all of the values_production.yaml files from charts there, on the basis that people were getting the wrong idea (!): bitnami/charts#5095

[oplancelot]

@leezen , do you have some update of this requirement? because there are so many helm values.yaml file in existing legancy environment. It is quite hard to rewrite into code. It is a really useful function to imgrate existing helm system smoothly.

I can't agree with you more，any update?

[squaremo]

I don't think this will be addressed as it's formulated -- the values.yaml file is part of the chart, not something you supply when you install the chart. When values-*.yaml files are included with the chart, they are as examples, or for overlaying on the defaults. To use them with the Helm command line tool, you would either refer to them with the flag -f to combine them with the defaults, or build you own chart which adapts the values.yaml file to your chosen defaults.

That said, helm.Chart does not support referring to a file for overlay values (https://www.pulumi.com/registry/packages/kubernetes/api-docs/helm/v3/chart/#inputs), the equivalent of -f, so there is certainly a lack here. The issue #659 covers that lack.

helm.Release does let you refer to files for values (https://www.pulumi.com/registry/packages/kubernetes/api-docs/helm/v3/release/#valueyamlfiles_go). If you can use a helm.Release instead of a helm.Chart, that will avoid the limitation of helm.Chart not supporting values from files.

I'm going to close this issue as "by design", since #659 addresses the problem given here, in line with how the Helm tooling itself works. (If anyone has a reason #659 cannot solve their problem in the way this issue would, we can always reopen this one.)