Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch protection: Require linear history #144

Closed
dududko opened this issue Jul 7, 2021 · 5 comments
Closed

Branch protection: Require linear history #144

dududko opened this issue Jul 7, 2021 · 5 comments
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@dududko
Copy link

dududko commented Jul 7, 2021

Please support the required_linear_history attribute in the BranchProtectionV3 api call.
@dududko dududko added the kind/enhancement Improvements or new features label Jul 7, 2021
@emiliza emiliza added the awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). label Jul 8, 2021
@emiliza
Copy link

emiliza commented Jul 8, 2021

This is currently blocked on the upstream provider - there's an open feature request there: integrations/terraform-provider-github#305 . Once that gets addressed we'll update on our end

@schmurfy
Copy link

schmurfy commented Oct 6, 2021

This was added as far as I can tell but it does not work for me using typescript, pulumi up detects that the flag requiredLinearHistory needs to be changed to true but when I run it, it changes nothing.
If I check the box on the branch protection rule on github and run a refresh it correctly detects that the value has changed.

@nesl247
Copy link

nesl247 commented Oct 25, 2021 •
edited
Loading

This was added as far as I can tell but it does not work for me using typescript, pulumi up detects that the flag requiredLinearHistory needs to be changed to true but when I run it, it changes nothing.
If I check the box on the branch protection rule on github and run a refresh it correctly detects that the value has changed.

I'm having the same issue. Probably related to integrations/terraform-provider-github#952

@schmurfy
Copy link

yes this is not related to pulumi itself.

@stack72 stack72 added resolution/fixed This issue was fixed and removed awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). labels Jun 13, 2022
@stack72
Copy link
Contributor

stack72 commented Jun 13, 2022

This has been supported upstream and we can close this out

@stack72 stack72 closed this as completed Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@schmurfy @stack72 @nesl247 @dududko @emiliza