Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetricDescriptor object lacks fields that exist in GCP API #215

Closed
flaksp opened this issue Sep 6, 2019 · 3 comments
Closed

MetricDescriptor object lacks fields that exist in GCP API #215

flaksp opened this issue Sep 6, 2019 · 3 comments

Comments

@flaksp
Copy link

flaksp commented Sep 6, 2019

Pulumi's interface:

interface MetricMetricDescriptor {
    labels?: pulumi.Input<pulumi.Input<inputs.logging.MetricMetricDescriptorLabel>[]>;
    metricKind: pulumi.Input<string>;
    valueType: pulumi.Input<string>;
}

Actual API: https://cloud.google.com/logging/docs/reference/v2/rest/v2/projects.metrics#MetricDescriptor

@pgavlin
Copy link
Member

pgavlin commented Sep 6, 2019

Which fields in particular do you need?

@flaksp
Copy link
Author

flaksp commented Sep 6, 2019

unit and displayName

@pgavlin
Copy link
Member

pgavlin commented Sep 7, 2019

These fields are missing because they are not supported by the upstream Terraform provider. unit will be added with the next release (see hashicorp/terraform-provider-google#3881); we will get support for the same once we pull in those changes.

I couldn't find an issue for displayName in the upstream provider, so I filed hashicorp/terraform-provider-google#4419. We'll use that issue to track adding support for that field.

@pgavlin pgavlin closed this as completed Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants