Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlanResourceChange causes failing tests related to buckets #1952

Closed
VenelinMartinov opened this issue Apr 24, 2024 · 1 comment
Closed

PlanResourceChange causes failing tests related to buckets #1952

VenelinMartinov opened this issue Apr 24, 2024 · 1 comment
Assignees
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@VenelinMartinov
Copy link
Contributor

What happened?

I attempted to enroll gcp bucket into PlanResourceChange and got a ton of failing tests. Debugged for a bit and noticed that our representation of labels has changed - no labels used to be stored as {} and change to nil after PlanResourceChange

Example

https://github.com/pulumi/pulumi-gcp/actions/runs/8804981419/job/24167273512

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@VenelinMartinov VenelinMartinov added kind/engineering Work that is not visible to an external user needs-triage Needs attention from the triage team labels Apr 24, 2024
@iwahbe iwahbe removed the needs-triage Needs attention from the triage team label Apr 25, 2024
@VenelinMartinov VenelinMartinov added the resolution/fixed This issue was fixed label Jul 1, 2024
@pulumi-bot pulumi-bot reopened this Jul 1, 2024
@pulumi-bot
Copy link
Contributor

Cannot close issue:

  • does not have an assignee

Please fix these problems and try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

3 participants