Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using Docker images that are already built locally #835

Closed
Tracked by #963
rlukata opened this issue Nov 8, 2023 · 3 comments
Closed
Tracked by #963

Allow using Docker images that are already built locally #835

rlukata opened this issue Nov 8, 2023 · 3 comments
Assignees
Labels
kind/enhancement Improvements or new features resolution/wont-fix This issue won't be fixed

Comments

@rlukata
Copy link

rlukata commented Nov 8, 2023

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

When using new docker.Image, check if there's an are already built image locally instead of having to rebuild them.

Affected area/feature

Docker

@rlukata rlukata added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Nov 8, 2023
@mikhailshilkov
Copy link
Member

Hi @rlukata Could you please provide a little bit more details about your idea? What is the main motivation to do so? Can you describe a use case where you would expect this to work? I expect there may be some difficulties in understanding whether a local image can be reused or not in all cases, but maybe you have a very specific scenario in mind?

@mikhailshilkov mikhailshilkov added awaiting-feedback Blocked on input from the author and removed needs-triage Needs attention from the triage team labels Nov 10, 2023
@rlukata
Copy link
Author

rlukata commented Nov 10, 2023

Hi @rlukata Could you please provide a little bit more details about your idea? What is the main motivation to do so? Can you describe a use case where you would expect this to work? I expect there may be some difficulties in understanding whether a local image can be reused or not in all cases, but maybe you have a very specific scenario in mind?

We heavily use S3 caching (cache-to and cahce-from) in CI, and since the pulumi-docker v4 API hasn't implemented these buildx features yet, we're having to build the images outside of pulumi. At the same time, we also have multiple resources that rely on those images being built and pushed to the registry.

I think that it would greatly simplify the orchestration and would be an elegant way to manage resource dependencies/relationships if I could build the images outside of pulumi -to leverage the ever-changing buildx features, and then use pulumi to push/deploy these images.

@pulumi-bot pulumi-bot added needs-triage Needs attention from the triage team and removed awaiting-feedback Blocked on input from the author labels Nov 10, 2023
@mikhailshilkov mikhailshilkov removed the needs-triage Needs attention from the triage team label Nov 10, 2023
@blampe blampe added the resolution/wont-fix This issue won't be fixed label Apr 25, 2024
@blampe
Copy link
Contributor

blampe commented Apr 25, 2024

and since the pulumi-docker v4 API hasn't implemented these buildx features yet

Hi @rlukata, we just released a new Docker Build provider focused exclusively on building images with buildx/BuildKit. It should provide all of the buildx features you need, and we recommend you use it for building images going forward. Please take a look and give us feedback!

The repository is here; our blog announcement is here; and finally API docs are here along with examples of how to migrate your existing Image resources to dockerbuild.Image.

We won't be able to add this functionality in this provider for a number of reasons, so I'm closing this as wont-fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/wont-fix This issue won't be fixed
Projects
None yet
Development

No branches or pull requests

4 participants