Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider default platform selections, windows/amd64 may not be the best default on Windows #534

Closed
AaronFriel opened this issue Mar 13, 2023 · 0 comments · Fixed by #543
Closed
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Milestone

Comments

@AaronFriel
Copy link
Contributor

AaronFriel commented Mar 13, 2023

The Image v4 resource defaults to, platform: "windows/amd64" on Windows assuming #535 is fixed, resulting in errors when building. The default platform behavior of the Docker daemon seems correct when platform: "" (the empty string).

The default behavior here may be the correct one, though we ought to investigate what macOS platforms perform here and what default is best there.

Given the same program as in #535:

name: image-yaml
description: A Docker image build
runtime: yaml
config: {}
variables: {}
resources:
  demo-image:
    type: docker:Image
    properties:
      imageName: username/image:tag1
      skipPush: true
      build:
        context: ./app
        platform: windows/amd64 # assuming this became the new default
    options:
      version: v4.0.0
outputs:
  imageName: ${demo-image.imageName}

With this Dockerfile:

FROM busybox:latest

COPY test.txt /

CMD ["cat", "test.txt"]

Results in this error:

error: failed to solve with frontend dockerfile.v0: failed to create LLB definition: no match for platform in manifest sha256:c118f538365369207c12e5794c3cbfb7b042d950af590ae6c287ede74f29b7d4: not found
error: update failed
@AaronFriel AaronFriel added kind/question Questions about existing features needs-triage Needs attention from the triage team labels Mar 13, 2023
@AaronFriel AaronFriel added p1 A bug severe enough to be the next item assigned to an engineer kind/bug Some behavior is incorrect or out of spec and removed needs-triage Needs attention from the triage team kind/question Questions about existing features labels Mar 13, 2023
@AaronFriel AaronFriel changed the title Consider default platform selections Consider default platform selections, windows/amd64 may not be the best default on Windows Mar 13, 2023
@AaronFriel AaronFriel added p1 A bug severe enough to be the next item assigned to an engineer and removed p1 A bug severe enough to be the next item assigned to an engineer labels Mar 13, 2023
@guineveresaenger guineveresaenger self-assigned this Mar 14, 2023
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Mar 15, 2023
@AaronFriel AaronFriel added this to the 0.86 milestone Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants