Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field containerLogs in docker:index/container:Container is incorrectly set as required #1052

Open
andrzejressel opened this issue Apr 3, 2024 · 2 comments · May be fixed by #1059
Open

Field containerLogs in docker:index/container:Container is incorrectly set as required #1052

andrzejressel opened this issue Apr 3, 2024 · 2 comments · May be fixed by #1059
Labels
customer/feedback Feedback from customers impact/breaking Fixing this issue will require a breaking change kind/bug Some behavior is incorrect or out of spec

Comments

@andrzejressel
Copy link

andrzejressel commented Apr 3, 2024 •
edited
Loading

What happened?

containerLogs is set as required in schema

pulumi-docker/provider/cmd/pulumi-resource-docker/schema.json

Lines 2406 to 2409 in aeabb7d

"required": [
"bridge",
"command",
"containerLogs",
while the description is "The logs of the container if its execution is done (attach must be disabled)." - and it indeed is not returned in persistent containers:

https://github.com/kreuzwerker/terraform-provider-docker/blob/54685a5fb9b375961620d2c555c7f3925327112c/internal/provider/resource_docker_container_funcs.go#L535-L581

This field is not required in original provider: https://github.com/kreuzwerker/terraform-provider-docker/blob/54685a5fb9b375961620d2c555c7f3925327112c/internal/provider/resource_docker_container.go#L123-L127

Example

N/A

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@andrzejressel andrzejressel added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Apr 3, 2024
@andrzejressel
Copy link
Author

There is also issue with healthcheck:

https://github.com/kreuzwerker/terraform-provider-docker/blob/54685a5fb9b375961620d2c555c7f3925327112c/internal/provider/resource_docker_container_funcs.go#L739-L749

https://github.com/pulumi/pulumi-docker/blob/master/provider/cmd/pulumi-resource-docker/schema.json#L2413

@blampe blampe linked a pull request Apr 8, 2024 that will close this issue
Open
@blampe
Copy link
Contributor

blampe commented Apr 8, 2024

This is a known issue with bridged providers which is unfortunately not easy to fix in a backwards-compatible way pulumi/pulumi-terraform-bridge#1239

I've put up a possible fix in #1059. As you can see it is not backwards-compatible with existing SDKs, so existing users could see their programs fail to compile by upgrading and we want to avoid that as much as possible.

It would be helpful to understand more about your use case -- is there anything unusual you're doing to trigger the bug?

@blampe blampe added customer/feedback Feedback from customers impact/breaking Fixing this issue will require a breaking change kind/task Work that's part of an ongoing epic and removed needs-triage Needs attention from the triage team labels Apr 8, 2024
@mikhailshilkov mikhailshilkov removed the kind/task Work that's part of an ongoing epic label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
customer/feedback Feedback from customers impact/breaking Fixing this issue will require a breaking change kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark some computed properties as optional pulumi/pulumi-docker
3 participants
@blampe @andrzejressel @mikhailshilkov