Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform-provider-dnsimple to v0.17.0 #455

Merged
merged 5 commits into from
Jul 19, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Jul 16, 2024

This PR was generated via $ upgrade-provider pulumi/pulumi-dnsimple --target-version v0.17.0.


  • Upgrading terraform-provider-dnsimple from 0.15.0 to 0.17.0.

This upgrades the provider from SDKv2 to PF and (BREAKING) drops the deprecated dnsimple_record resource. It depends on pulumi/pulumi-terraform-bridge#2155, released in v3.87.0.

This demonstrates that pulumi/pulumi-terraform-bridge#1198 can be worked around.

Fixes pulumi/pulumi-terraform-bridge#1198

@iwahbe iwahbe self-assigned this Jul 16, 2024
@iwahbe iwahbe force-pushed the upgrade-terraform-provider-dnsimple-to-v0.17.0 branch from eea570b to c1aa538 Compare July 16, 2024 21:33
Copy link

github-actions bot commented Jul 16, 2024

Does the PR have any schema changes?

Found 10 breaking changes:

Resources

  • "dnsimple:index/letsEncryptCertificate:LetsEncryptCertificate":
    • 🟡 inputs: "contactId" missing
    • properties:
      • 🟡 "contactId" missing output "contactId"
      • 🟡 "expiresOn" missing output "expiresOn"
    • 🟢 required inputs: "domainId" input has changed to Required
  • 🔴 "dnsimple:index/record:Record" missing
  • "dnsimple:index/zoneRecord:ZoneRecord":
    • inputs:
      • 🟡 "priority" type changed from "string" to "integer"
      • 🟡 "ttl" type changed from "string" to "integer"
    • properties:
      • 🟡 "priority" type changed from "string" to "integer"
      • 🟡 "ttl" type changed from "string" to "integer"

Functions

  • 🟡 "dnsimple:index/getCertificate:getCertificate": inputs: "certificateId" type changed from "string" to "integer"
    No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@iwahbe iwahbe force-pushed the upgrade-terraform-provider-dnsimple-to-v0.17.0 branch 3 times, most recently from ae6f8ce to 608ee1c Compare July 17, 2024 21:33
@iwahbe iwahbe force-pushed the upgrade-terraform-provider-dnsimple-to-v0.17.0 branch from 608ee1c to c55e0f0 Compare July 17, 2024 22:30
@iwahbe iwahbe requested review from guineveresaenger and a team July 18, 2024 18:15
Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string/int irregularity probably warrants a comment, but this LGTM.

provider/resources.go Show resolved Hide resolved
@iwahbe iwahbe merged commit 6e3336c into master Jul 19, 2024
23 checks passed
@iwahbe iwahbe deleted the upgrade-terraform-provider-dnsimple-to-v0.17.0 branch July 19, 2024 21:37
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.5.0.

@mjeffryes mjeffryes added this to the 0.107 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform-provider-vantage blocked on numeric ID support
4 participants