Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type mismatch for DropletId when creating a new reserved IP #849

Open
nmathew98 opened this issue Oct 22, 2024 · 4 comments
Open

Type mismatch for DropletId when creating a new reserved IP #849

nmathew98 opened this issue Oct 22, 2024 · 4 comments
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@nmathew98
Copy link

Describe what happened

NewReservedIp accepts ReservedIpArgs which has a field DropletId of type pulumi.IntPtrInput but when creating a NewDroplet the ID available is of type pulumi.IDOutput

NewDroplet
Image

ReservedIpArgs
Image

Sample program

main.go.txt

Log output

pulumi.log

Affected Resource(s)

  • NewDroplet
  • NewReservedIp

Output of pulumi about

CLI
Version 3.129.0
Go Version go1.22.6
Go Compiler gc

Plugins
KIND NAME VERSION
resource cloudflare 5.41.0
resource digitalocean 4.34.0
language go unknown

Host
OS alpine
Version 3.20.2
Arch aarch64

This project is written in go: executable='/usr/local/go/bin/go' version='go version go1.23.0 linux/arm64'

Current Stack: skulpture/brittle-systems/statamic

Found no resources associated with statamic

Found no pending operations associated with statamic

Backend
Name pulumi.com
URL https://app.pulumi.com/skulpture
User skulpture
Organizations skulpture
Token type personal

Dependencies:
NAME VERSION
github.com/dogmatiq/ferrite v1.4.0
github.com/pulumi/pulumi-cloudflare/sdk/v5 v5.41.0
github.com/pulumi/pulumi-digitalocean/sdk/v4 v4.34.0
github.com/pulumi/pulumi/sdk/v3 v3.136.1

Pulumi locates its logs in /tmp by default

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@nmathew98 nmathew98 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Oct 22, 2024
@nmathew98
Copy link
Author

nmathew98 commented Oct 27, 2024

for reference, solved by:

Image

its a little awkward and docs don't specify this either, https://www.pulumi.com/registry/packages/digitalocean/api-docs/reservedip/:

Image

@VenelinMartinov
Copy link
Contributor

Hey @nmathew98. Thanks for reporting the type mismatch and glad you managed to work around it. This is quite unfortunate but we can not fix it without causing a breaking change in user programs.

There is an issue we've opened to consider this, feel free to +1 it: #600

@VenelinMartinov VenelinMartinov removed the needs-triage Needs attention from the triage team label Oct 28, 2024
@nmathew98
Copy link
Author

nmathew98 commented Oct 28, 2024

@VenelinMartinov can I update the docs, I think if there's other breaking changes sure but don't feel it motivates a major bump on its own just docs should specify it

@VenelinMartinov
Copy link
Contributor

Thanks for volunteering @nmathew98 but unfortunately our current build process is quite involved, so you'd find it challenging to leave edit the docs directly. We are working on making it more accessible but it is not there yet.

Can I ask you to leave a comment with your suggestion in #600 instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

2 participants