Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App proxy settings for Service Principal #1301

Open
asiqq23 opened this issue Aug 22, 2024 · 1 comment
Open

App proxy settings for Service Principal #1301

asiqq23 opened this issue Aug 22, 2024 · 1 comment
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/enhancement Improvements or new features

Comments

@asiqq23
Copy link

asiqq23 commented Aug 22, 2024

Describe what happened

When we create app registration and service principal via Pulumi in Azure we obseve some differences in view and API response from Azure.
For enterprise app we created via Pulumi we get appType:3 but for enterprise app created via Azure portal we get appType:1.

Screenshot shows that app created via Pulumi has missing fileds in UI. So this might exaplain that app created via Pulumi is not same type as from the portal. We suspect that might be also blocking us to setup app proxy over app created via Pulumi.

Is there any API in portal Azure that can control what kind of service princial is being created?

We are using Azure Native 2.* in this project

This one contains less props on Properties, created via Pulumi

Image

This one contains more props on Properties, created via Portal

Image

Sample program

var app = new Application(appRegistrationName, new ApplicationArgs
        {
            DisplayName = appRegistrationName,
            Web = new ApplicationWebArgs()
            {
                LogoutUrl = "https://url.company.org/?appproxy=logout",
                RedirectUris = new[] { "https://url.company.org/" }
            }
        });`

var servicePrincipal = new ServicePrincipal(appRegistrationName, new ServicePrincipalArgs
        {
            AppRoleAssignmentRequired = true,
            ClientId = app.ClientId.Apply(id => id),
            AccountEnabled = true,
            LoginUrl = "https://url.company.org/",
            Tags = new[]
            {
                "WindowsAzureActiveDirectoryIntegratedApp",
                "WindowsAzureActiveDirectoryOnPremApp"
            },
        });

Log output

No response

Affected Resource(s)

No response

Output of pulumi about

`Extracting package 'M:\Octopus\Packages\Spaces-1\feeds-builtin\Komplett.CaaS\Komplett.CaaS.2.5.52.zip' to 'C:\Octopus\Work\20240822104358-477856-536\Komplett.CaaS' 
August 22nd 2024 12:44:15Info
CLI           
August 22nd 2024 12:44:15Info
Version      3.111.1 
August 22nd 2024 12:44:15Info
Go Version   go1.22.1 
August 22nd 2024 12:44:15Info
Go Compiler  gc 
August 22nd 2024 12:44:15Info
Host      
August 22nd 2024 12:44:15Info
OS       Microsoft Windows Server 2019 Datacenter 
August 22nd 2024 12:44:15Info
Version  10.0.17763 Build 17763 
August 22nd 2024 12:44:15Info
Arch     x86_64 
August 22nd 2024 12:44:15Info
Pulumi locates its logs in C:\windows\TEMP by default 

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@asiqq23 asiqq23 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Aug 22, 2024
@danielrbradley
Copy link
Member

Hi @asiqq23 this will need to be implemented in the upstream terraform-provider-azuread provider then will be made available in this Pulumi provider in the subsequent release.

It looks like what you're asking for might be the same as this existing issue if you want to upvote that one:

@danielrbradley danielrbradley added awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/enhancement Improvements or new features and removed needs-triage Needs attention from the triage team kind/bug Some behavior is incorrect or out of spec labels Aug 23, 2024
@danielrbradley danielrbradley changed the title Service Principal created via Pulumi code can't have app proxy settings App proxy settings for Service Principal Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants