Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources not cleaned up from test, incurring ongoing charges in Aiven account #235

Closed
3 of 4 tasks
AaronFriel opened this issue Jan 19, 2023 · 9 comments · Fixed by #774
Closed
3 of 4 tasks

Resources not cleaned up from test, incurring ongoing charges in Aiven account #235

AaronFriel opened this issue Jan 19, 2023 · 9 comments · Fixed by #774
Assignees
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@AaronFriel
Copy link
Contributor

AaronFriel commented Jan 19, 2023

  • Suspend tests
  • Document account (likely [email protected]) used: answer - in engineering team 1password vault.
  • Clean up outstanding resources in account
  • Follow up with @isaac-pulumi on approach to re-enable tests or future steps.
@AaronFriel AaronFriel added kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer labels Jan 19, 2023
@AaronFriel AaronFriel self-assigned this Jan 19, 2023
@AaronFriel AaronFriel removed the p1 A bug severe enough to be the next item assigned to an engineer label Jan 20, 2023
@AaronFriel
Copy link
Contributor Author

Removing P1 and keeping this as a tracking issue.

@guineveresaenger
Copy link
Contributor

I recommend a cleaner-upper, which has been used as a solution in other providers: https://github.com/pulumi/civo-account-cleanup

@AaronFriel AaronFriel added this to the 0.84 milestone Feb 2, 2023
@AaronFriel AaronFriel modified the milestones: 0.84, 0.85 Feb 13, 2023
@t0yv0
Copy link
Member

t0yv0 commented Mar 23, 2023

Just merged something that enables tests back, should they still be skipped?

@AaronFriel
Copy link
Contributor Author

We should keep this open for a while, I'll track our Aiven portal and cron workflow to see if we're leaving resources alive. There's an upstream issue enabling us to tweak timeouts via a fork + patch or ldflags:

@t0yv0
Copy link
Member

t0yv0 commented Mar 23, 2023

Also pulumi/ci-mgmt#379 perhaps relevant.

I don't mind keeping this open, just FYI more tests are running now in Aiven that were skipped before today. Just in case this causes further problems.

@AaronFriel
Copy link
Contributor Author

AaronFriel commented Mar 24, 2023

In the case of this issue, the cleanup failed due to provider timeouts. The physical resource creation succeeded async after the provider timed out, so the logical resource create call failed. The state file thus had no resources to clean up when programtest ran pulumi destroy.

@mikhailshilkov mikhailshilkov modified the milestones: 0.85, 0.87 Apr 3, 2023
@mikhailshilkov mikhailshilkov removed this from the 0.87 milestone Apr 26, 2023
@iwahbe iwahbe added kind/engineering Work that is not visible to an external user and removed kind/bug Some behavior is incorrect or out of spec labels Sep 26, 2024
@iwahbe
Copy link
Member

iwahbe commented Sep 26, 2024

Tests are no longer suspended.

@mjeffryes
Copy link
Member

Looks like we had another resource leak. I'm going to disable tests again.

@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #774 and shipped in release v6.29.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants