Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProviderTests fail in PreviewOnly when Invokes are involved #31

Closed
t0yv0 opened this issue Nov 13, 2023 · 2 comments · Fixed by #105
Closed

ProviderTests fail in PreviewOnly when Invokes are involved #31

t0yv0 opened this issue Nov 13, 2023 · 2 comments · Fixed by #105
Assignees
@danielrbradley
Labels
kind/bug Some behavior is incorrect or out of spec kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@t0yv0
Copy link
Member

t0yv0 commented Nov 13, 2023

What happened?

The snapshots no longer sufficient to move the test forward without actually deploying infra.

Example

TBD

Output of pulumi about

TBD.

Additional context

N/A

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@t0yv0 t0yv0 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Nov 13, 2023
@t0yv0
Copy link
Member Author

t0yv0 commented Nov 13, 2023 •
edited
Loading

Sounds like almost EKS tests and some AWSX tests are affected by this limitation. Without mocking out the Invoke calls in some way, we are limited to running full-mode tests only, which is very unfortunate in case of EKS as these tests take a long time to run.

@mjeffryes mjeffryes added kind/engineering Work that is not visible to an external user and removed needs-triage Needs attention from the triage team labels Feb 1, 2024
@danielrbradley danielrbradley mentioned this issue Aug 30, 2024
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Sep 6, 2024
@pulumi-bot
Copy link

This issue has been addressed in PR #105 and shipped in release v0.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielrbradley danielrbradley

Labels
kind/bug Some behavior is incorrect or out of spec kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add provider.ReplayInvokes pulumi/providertest
4 participants
@t0yv0 @danielrbradley @mjeffryes @pulumi-bot