Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a locale-independent comparison #2

Open
1 task done
ottok opened this issue Sep 23, 2023 · 5 comments
Open
1 task done

Use a locale-independent comparison #2

ottok opened this issue Sep 23, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@ottok
Copy link

ottok commented Sep 23, 2023

Have you checked for existing feature requests?

  • Completed

Summary

The PR at atom#36 by @notslang seems useful, we should ask him to resubmit the PR against the Pulsar fork.

What benefits does this feature provide?

Using a locale-independent comparison has slightly better performance, and is more stable (since it doesn't rely upon the configured locale).

Any alternatives?

No alternatives, or to just do nothing.

Other examples:

I would also support the suggestion atom#107 by @wesinator.

@ottok ottok added the enhancement New feature or request label Sep 23, 2023
@confused-Techie
Copy link
Member

Thanks a ton for contributing!

We have been talking about the process we want to enforce for taking on additional core packages, so this could be the perfect test package to iron out that process, even if it isn't added.

But it may be difficult to ask that contributor to add the PR again, as that repo is archived, and we are unable to comment on it.

But a reimplementation of it wouldn't be a bad idea at all.

@ottok
Copy link
Author

ottok commented Sep 23, 2023

If we mention the original author @notslang here, will they not get a notification?

@confused-Techie
Copy link
Member

If we mention the original author @notslang here, will they not get a notification?

You've got a valid point there. Don't know why I didn't think of that. So guess we can wait a moment and see if they are up to revisiting a PR from 2015. But otherwise this seems like a fine addition to add ourselves otherwise.

@notslang
Copy link

I don't use Pulsar, but you're welcome to take that PR and use it wherever you want. Happy you found it useful! ❤️

@confused-Techie
Copy link
Member

I don't use Pulsar, but you're welcome to take that PR and use it wherever you want. Happy you found it useful! ❤️

Thanks a ton for taking the time to respond! And of course for being fine with us using the PR content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants