-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PULP-76] Remove is highest #2039
base: main
Are you sure you want to change the base?
Conversation
This allows uploads of different files claiming to be the same collections into different repositories. relates to pulp#1052
5f7461f
to
ae7321e
Compare
@jctanner The description about the search vector sounds scary in this context. Shouldn't search be broken, when the search vector does no longer receive updates? |
@mdellweg what "search" are you referring to? Galaxy's "search" function is https://github.com/pulp/pulp_ansible/blob/main/pulp_ansible/app/galaxy/v3/viewsets.py#L65, which uses https://github.com/pulp/pulp_ansible/blob/main/pulp_ansible/app/models.py#L616 which has it's own flag for "is_highest" ... https://github.com/pulp/pulp_ansible/blob/main/pulp_ansible/app/tasks/collectionversion_index.py#L198 |
# a migration file. The trigger only runs when the table is | ||
# updated. CollectionVersions are INSERT'ed into the table, so | ||
# the search_vector does not get populated at initial creation | ||
# time. In the import or sync workflows, is_highest gets toggled | ||
# back and forth, which causes an UPDATE operation and then the | ||
# search_vector is built. | ||
# time. | ||
search_vector = psql_search.SearchVectorField(default="") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering about this search vector.
No description provided.