An error is raised when running pulp domain in a container with two domains

[lubosmj]

$ pulp domain list

Traceback (most recent call last):
  File "/usr/local/bin/pulp", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.8/site-packages/pulp_cli/__init__.py", line 33, in main
    return _main()
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.8/site-packages/pulpcore/cli/common/generic.py", line 179, in invoke
    return super().invoke(ctx)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1655, in invoke
    sub_ctx = cmd.make_context(cmd_name, args, parent=ctx)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 920, in make_context
    self.parse_args(ctx, args)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1613, in parse_args
    rest = super().parse_args(ctx, args)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1378, in parse_args
    value, args = param.handle_parse_result(ctx, opts, args)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 2356, in handle_parse_result
    value, source = self.consume_value(ctx, opts)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 2890, in consume_value
    value, source = super().consume_value(ctx, opts)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 2247, in consume_value
    value = ctx.lookup_default(self.name)  # type: ignore
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 664, in lookup_default
    value = self.default_map.get(name)
AttributeError: 'str' object has no attribute 'get'

The command domains works as expected. However, this is not a recommended way of tampering with domains as the warning mentions.

$ pulp domains list

Please use 'domain' instead of 'domains'.
[
  {
    "pulp_href": "/pulp/default/api/v3/domains/018cfe55-95b6-7bb4-833f-a701971fa4cc/",
    "pulp_created": "2024-01-12T15:41:10.967249Z",
    "name": "domain_for_otel_testing",
    "description": null,
    "storage_class": "pulpcore.app.models.storage.FileSystem",
    "storage_settings": {
      "hidden_fields": [],
      "location": "/var/lib/pulp/media_otel/",
      "base_url": "",
      "file_permissions_mode": 420,
      "directory_permissions_mode": null
    },
    "redirect_to_object_storage": true,
    "hide_guarded_distributions": false
  },
  {
    "pulp_href": "/pulp/default/api/v3/domains/018cfdd1-51c8-7cdc-a654-be9fcab28460/",
    "pulp_created": "2024-01-12T13:16:42.825356Z",
    "name": "default",
    "description": null,
    "storage_class": "pulpcore.app.models.storage.FileSystem",
    "storage_settings": {
      "hidden_fields": [],
      "location": "/var/lib/pulp/media",
      "base_url": "/",
      "file_permissions_mode": 420,
      "directory_permissions_mode": null
    },
    "redirect_to_object_storage": true,
    "hide_guarded_distributions": false
  }
]

pulp3 command line interface, version 0.20.2

[mdellweg]

Since when is default_map a string? What's going wrong there?

[lubosmj]

As I am thinking about it, is not the issue #769 related to this? I did not make any changes to the configuration. I just started a new oci-env container, shelled into it and ran pulp domain.

[mdellweg]

As I am thinking about it, is not the issue #769 related to this? I did not make any changes to the configuration. I just started a new oci-env container, shelled into it and ran pulp domain.

Yes, that rings a bell. Do you specify "domain" in the settings?

[lubosmj]

Maybe, we should backport #772 to 0.20 since it comes pre-installed with oci-env.

[lubosmj]

Yes, there is "default" domain specified:

[cli]
base_url = "http://localhost:5001"
api_root = "/pulp/"
username = "admin"
password = "password"
domain = "default"
cert = ""
key = ""
verify_ssl = true
format = "json"
dry_run = false
timeout = 0
verbose = 0

[mdellweg]

Maybe, we should backport #772 to 0.20 since it comes pre-installed with oci-env.

#863

Also why does it preinstall an old version?

[lubosmj]

Because, it is pinned there: https://github.com/pulp/oci_env/blob/3fd2c2486fe9f95ebcf841d6fb3fde24c345d83b/base/dev_requirements.txt#L6.

I opened this: https://github.com/pulp/oci_env/pull/149/files.

[mdellweg]

The fix has been backported now.