Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signing service inspection commands #189

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Add signing service inspection commands #189

merged 1 commit into from
Apr 28, 2021

Conversation

mdellweg
Copy link
Member

fixes #TBA

@mdellweg
Copy link
Member Author

mdellweg commented Mar 29, 2021 •
edited
Loading

I want to find a way to make this testable before merging.
It is now.

mdellweg added a commit to mdellweg/pulp-cli that referenced this pull request Apr 1, 2021
@mdellweg
Add signing service inspection commands
ad5d8ea 
fixes pulp#189
@mdellweg mdellweg force-pushed the signing branch 5 times, most recently from b4366a7 to d2f7593 Compare April 1, 2021 18:33
@mdellweg mdellweg marked this pull request as ready for review April 1, 2021 20:13
@mdellweg mdellweg added this to the 0.8.0 milestone Apr 2, 2021
ggainey
ggainey requested changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@ggainey ggainey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we detach the import/export changes from this PR? Otherwise, this looks great!

pulpcore/cli/core/context.py Outdated
@@ -86,7 +86,7 @@ def upload(self, file: IO[bytes], chunk_size: int = 1000000, check_exists: bool


class PulpExporterContext(PulpEntityContext):
ENTITY = "PulpExporter"
ENTITY = "pulp exporter"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be part of this PR?

pulpcore/cli/core/context.py Outdated Show resolved Hide resolved
pulpcore/cli/core/context.py Outdated Show resolved Hide resolved
tests/assets/setup_signing_service.py Show resolved Hide resolved
tests/assets/sign_deb_release.sh Show resolved Hide resolved
@mdellweg mdellweg requested a review from ggainey April 26, 2021 17:28
ggainey
ggainey approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@ggainey ggainey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mdellweg mdellweg merged commit 70c6a76 into pulp:develop Apr 28, 2021
@mdellweg mdellweg deleted the signing branch April 28, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggainey ggainey ggainey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mdellweg @ggainey