Add config profile option #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
force-pushed
the
config_profile
branch
2 times, most recently
from
e314111 to
026163e
Compare
|
This looks good to me. 👍 |
mdellweg
force-pushed
the
config_profile
branch
from
026163e to
8404f11
Compare
|
I'm going to add some tests... |
mdellweg
force-pushed
the
config_profile
branch
from
8404f11 to
7afdae0
Compare
|
I moved some tests i think are not testing pulpcore in any reasonable way out of the pulpcore test directory. |
mdellweg
force-pushed
the
config_profile
branch
from
7afdae0 to
dece7be
Compare
daviddavis
reviewed
Feb 20, 2021
tests/scripts/test_config.sh
Outdated
| @@ -29,6 +30,14 @@ expect_fail pulp --username test --password test --client "/some/path" status | |||
| expect_fail pulp --key "/some/path" file remote list | |||
|
|
|||
|
|
|||
| # CONFFIG PROFILE | |||
There was a problem hiding this comment.
Suggested change
| # CONFFIG PROFILE | |
| # CONFIG PROFILE |
There was a problem hiding this comment.
Hmm this keyboard of mine is really oversensitive...
daviddavis
approved these changes
Feb 20, 2021
mdellweg
force-pushed
the
config_profile
branch
2 times, most recently
from
995ede4 to
3f7cc1f
Compare
This allows to select different profiles from the config file to load a different set of default values. The default profile is the one with the section name "cli". Other profiles can be provided by adding sections with names like "cli-<profile>". The profile "cli-sandbox" e.g. can be selected with "pulp --profile sandbox <...>". [noissue]
mdellweg
force-pushed
the
config_profile
branch
from
3f7cc1f to
8b6bcb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a request for comment.
Do we want something like this?