Added worker command. #144
Conversation
| @@ -0,0 +1 @@ | |||
| Added worker command. | |||
There was a problem hiding this comment.
Meh, self referencing does not seem to work. But i like the idea of having a changelog without the need to file an issue just to say: This is what i do in the PR anyway.
OTOH, i thought gh handles PRs as a special sort of issues.
It should work however if you do not put the fixes in the commit message. Which means we should add more checking for spurious changelog snippets. What if "(no [noissue]) and (no fixes #??)" implies we need one for the PR number?
log.out
Outdated
| @@ -0,0 +1 @@ | |||
| [{"pulp_created": "2021-02-13T13:33:04.220502Z", "pulp_href": "/pulp/api/v3/workers/3754d4ea-b554-432d-b20e-45026ce46c12/", "name": "resource-manager", "last_heartbeat": "2021-02-13T22:16:02.245766Z"}] | |||
There was a problem hiding this comment.
Those files i would not expect here. Is the cwd mechanism not working for you?
There was a problem hiding this comment.
I don't know. I re-ran the tests and it didn't appear. Will keep an eye out.
| ] | ||
|
|
||
| worker.add_command(list_command(decorators=filter_options)) | ||
| worker.add_command(show_command(decorators=[href_option, name_option])) |
There was a problem hiding this comment.
Whenever i think, this is a lot of boilerplate, i need to remind myself, that it would be ca. 8-16 times the code if spelled out here in more detail...
| click.option("--name-contains", "name__contains"), | ||
| click.option("--name-icontains", "name__icontains"), | ||
| click.option("--missing/--not-missing", default=None), | ||
| click.option("--online/--not-online", default=None), |
There was a problem hiding this comment.
So this is how you make a tristate option. 👍
daviddavis
force-pushed
the
worker
branch
2 times, most recently
from
0e44b17 to
fe2a4ba
Compare
[noissue]
|
The approval stands. ;) |
fixes #144