From 819fa203d3711197730aa3d537c9e4ae936d9990 Mon Sep 17 00:00:00 2001
From: Lubos Mjachky <lmjachky@redhat.com>
Date: Wed, 1 Jun 2022 19:44:37 +0200
Subject: [PATCH] Add a note about including whitespace characters

[noissue]
---
 pulpcore/cli/common/generic.py | 28 ++++++++++++++++++++++++----
 pulpcore/cli/rpm/remote.py     | 14 ++++++++++++--
 2 files changed, 36 insertions(+), 6 deletions(-)

diff --git a/pulpcore/cli/common/generic.py b/pulpcore/cli/common/generic.py
index e2287d13a..0929aa52b 100644
--- a/pulpcore/cli/common/generic.py
+++ b/pulpcore/cli/common/generic.py
@@ -655,10 +655,20 @@ def _type_callback(ctx: click.Context, param: click.Parameter, value: Optional[s
     click.option(
         "--download-concurrency", type=int, help=_("total number of simultaneous connections")
     ),
-    click.option("--password"),
+    click.option(
+        "--password",
+        help=_(
+            "The password to authenticate to the remote (can contain leading and trailing spaces)."
+        ),
+    ),
     click.option("--proxy-url"),
     click.option("--proxy-username"),
-    click.option("--proxy-password"),
+    click.option(
+        "--proxy-password",
+        help=_(
+            "The password to authenticate to the proxy (can contain leading and trailing spaces)."
+        ),
+    ),
     click.option("--rate-limit", type=int, help=_("limit download rate in requests per second")),
     click.option("--sock-connect-timeout", type=float),
     click.option("--sock-read-timeout", type=float),
@@ -688,10 +698,20 @@ def _type_callback(ctx: click.Context, param: click.Parameter, value: Optional[s
     click.option(
         "--download-concurrency", type=int, help=_("total number of simultaneous connections")
     ),
-    click.option("--password"),
+    click.option(
+        "--password",
+        help=_(
+            "The password to authenticate to the remote (can contain leading and trailing spaces)."
+        ),
+    ),
     click.option("--proxy-url"),
     click.option("--proxy-username"),
-    click.option("--proxy-password"),
+    click.option(
+        "--proxy-password",
+        help=_(
+            "The password to authenticate to the proxy (can contain leading and trailing spaces)."
+        ),
+    ),
     click.option("--rate-limit", type=int, help=_("limit download rate in requests per second")),
     click.option("--sock-connect-timeout", type=float),
     click.option("--sock-read-timeout", type=float),
diff --git a/pulpcore/cli/rpm/remote.py b/pulpcore/cli/rpm/remote.py
index fa89cfd7b..4a5177a26 100644
--- a/pulpcore/cli/rpm/remote.py
+++ b/pulpcore/cli/rpm/remote.py
@@ -71,13 +71,23 @@ def remote(ctx: click.Context, pulp_ctx: PulpContext, remote_type: str) -> None:
     click.option(
         "--download-concurrency", type=int, help=_("total number of simultaneous connections")
     ),
-    click.option("--password"),
+    click.option(
+        "--password",
+        help=_(
+            "The password to authenticate to the remote (can contain leading and trailing spaces)."
+        ),
+    ),
     click.option(
         "--policy", type=click.Choice(["immediate", "on_demand", "streamed"], case_sensitive=False)
     ),
     click.option("--proxy-url"),
     click.option("--proxy-username"),
-    click.option("--proxy-password"),
+    click.option(
+        "--proxy-password",
+        help=_(
+            "The password to authenticate to the proxy (can contain leading and trailing spaces)."
+        ),
+    ),
     click.option("--rate-limit", type=int, help=_("limit download rate in requests per second")),
     pulp_option("--sles-auth-token", allowed_with_contexts=(PulpRpmRemoteContext,)),
     click.option("--sock-connect-timeout", type=float),