-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a single commit check workflow #494
Conversation
Stolen from Katello: https://github.com/Katello/katello/blob/master/.github/workflows/pull_request.yml I'm imagining that this will be a non-blocking test. In other words, it won't prevent merges. It will just help to warn contributors/PR reviewers that there's more than one commit. |
9e9623f
to
808e52f
Compare
Awesome! Will this be enabled by default or do plugins need to opt-in? I'm +1 to enabling by default and opting out, but I'm ok w/ whatever you decide. |
Thanks I forgot to set a default. I'm imagining it'll be enabled by default too. |
808e52f
to
915ae45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of liked the discourse announcement part. :) Thanks for doing this!
Ha yea, that was a WIP I didn't mean to commit yet. Eventually I want to have the release automation automatically post the announcement to discourse. |
61f3d23
to
9c8bd55
Compare
[noissue]
9c8bd55
to
6b77c8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I will set it to false on galaxy_ng on next ci update.
We allow multiple commits because we enforce Squash and Merge.
I think I will also opt out pulp_deb. The PR volume is not so high that I feel the need to enforce single commits via automation. |
Can this check be used to set/delete a "multiple commit" label on the PR, instead of presenting a failed test? |
I think we could if we used a |
[noissue]