Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong parameter name C_FLAG in fpu_shared.sv? #8

Open
tovine opened this issue May 15, 2018 · 2 comments
Open

Wrong parameter name C_FLAG in fpu_shared.sv? #8

tovine opened this issue May 15, 2018 · 2 comments

Comments

@tovine
Copy link
Contributor

tovine commented May 15, 2018

In the file fpu_shared.sv a parameter called C_FLAG is referred, which I can't find in the imported package fpu_defs.

   logic [C_FLAG-1:0] Flags_S;

I'm assuming it is a typo and that it should instead be C_FFLAG, or have I missed something?

@tovine
Copy link
Contributor Author

tovine commented May 15, 2018

Also: where is C_TAG defined? Could not find it from the root directory of the top pulp project (after running update-ips.

It is referred to several places in fpu_shared.sv:

logic [C_TAG-1:0] Tag_D;
logic [C_TAG-1:0] Tag_DN;
logic [C_TAG-1:0]  TagDelayed_DP;
logic [C_TAG-1:0]  TagDelayed_DN;

@tovine
Copy link
Contributor Author

tovine commented Jun 11, 2018

Update: after some digging I found that these constants were removed in this commit: ad74409#diff-33d976666548c67ed8fa812b20ddfe81

-   parameter C_FLAG    = 9;
-   parameter C_TAG     = 7;
+   parameter C_FFLAG         = 5;

I therefore assume that these modules are not really maintained at the moment or that the parameters come from somewhere else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant