Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Verilator] Don't import deprecated SRAM with verilator #249

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[Verilator] Don't import deprecated SRAM with verilator #249

merged 1 commit into from
Dec 4, 2024

Conversation

Scheremo
Copy link
Contributor

The deprecated SRAM imported with simulation breaks with verilator. This PR excludes said module from being imported with verilator.

niwis
niwis approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@niwis niwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure if simulation should be set together with verilator in the first place, though (see here, although this requirement might be pre-Verilator5).

@niwis niwis merged commit f36828f into master Dec 4, 2024
5 checks passed
@niwis niwis deleted the scheremo/verilator branch December 4, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niwis niwis niwis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Scheremo @niwis