stream_xbar
: Fix non-existing output assertion
#204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #200 fixed an issue in the
stream_xbar
assertions, effectively enabling them when reset is not asserted:https://github.com/pulp-platform/common_cells/pull/200/files#diff-872c7e67b01645ac7cc6cecf1dbb01b73f1b1882d8bb77089dcb27570c35ac23L169
Thanks to this, a bug in one of the assertions was revealed:
common_cells/src/stream_xbar.sv
Lines 172 to 176 in 52f83ee
sel_oup_t
can represent values in the range [0,NumOut
). Because of this, if for exampleNumOut
is 32, the comparison will reduce tosel_i[i] < 0
which will never be satisfied.This PR fixes this issue.