hw: Add AW cuts to chimneys #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a deadlock potential if the downstream AXI network tries to sync the AW and W channel. This is sometimes necessary and also allowed by the AXI specifications (e.g. the
axi_to_memmodule needs address and data at the same time to generate a memory request). The problem with FlooNoC is that AW and W are sent over the same channels, which can causes a deadlock if the downstream AXI network waits for the W to be valid, which waits for the AW to be consumed.This PR fixes this by buffering the AWs. Since corresponding AWs and W are guaranteed to be consecutive (due to ordering issues), a buffer of size 1 is already enough to solve this deadlock situation.