Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can pstool please set labels on PR #2352

Open
dnsguru opened this issue Dec 19, 2024 · 0 comments · May be fixed by #2353
Open

Can pstool please set labels on PR #2352

dnsguru opened this issue Dec 19, 2024 · 0 comments · May be fixed by #2353
Labels
✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# ❌FAIL - DNS VALIDATION Unable to confirm _PSL TXT = This PR # (also see #1439) ❌FAIL - FIX SORTING ⏬ https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important ✔️Sorting Validated https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important

Comments

@dnsguru
Copy link
Member

dnsguru commented Dec 19, 2024

pstool test is working reasonably well. Wanted to have it set fail/pass labels for sorting and _PSL txt etc

When the DNS check passes (or fails), or the sorting test passes (or fails) have the pstool set (and/or unset) the label to either of the respective pass/fail conditions?
@dnsguru dnsguru added ❌FAIL - DNS VALIDATION Unable to confirm _PSL TXT = This PR # (also see #1439) ❌FAIL - FIX SORTING ⏬ https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important ✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# ✔️Sorting Validated https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important labels Dec 19, 2024
@fakeboboliu fakeboboliu linked a pull request Dec 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# ❌FAIL - DNS VALIDATION Unable to confirm _PSL TXT = This PR # (also see #1439) ❌FAIL - FIX SORTING ⏬ https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important ✔️Sorting Validated https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set label on PR based on check result fakeboboliu/psl
1 participant
@dnsguru