Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra search option #54

Open
avsingh999 opened this issue Oct 17, 2018 · 8 comments
Open

Remove extra search option #54

avsingh999 opened this issue Oct 17, 2018 · 8 comments

Comments

@avsingh999
Copy link
Member

there are two search option
ezgif com-video-to-gif

What happened before you saw the error

What you expected to happen

one search option should be remove

Browser, version, and operating system

firefox ubuntu 16.04 LTS
(to help reproduce the issue)

For bug reports, fill out the above template; for feature requests, you can delete the template.

@avsingh999
Copy link
Member Author

@jywarren @SidharthBansal @ebarry please look this issue and add label if this is valid
thank you :)

@SidharthBansal
Copy link
Member

Can you please send screenshot of the page we get after searching a particular text. I guess then there will be only a single search option.
Thanks for ui suggestion.

@avsingh999
Copy link
Member Author

@SidharthBansal please look this, thanks

ss3

@SidharthBansal
Copy link
Member

@jywarren which one should be removed?

@SidharthBansal
Copy link
Member

This task is published on GCI dashboard. Thanks all.

@jywarren
Copy link
Member

Hmm, this is hard because the one in the header appears on /all/ pages, but only if you click it.

I guess the way to solve this would be to have it check if there is already a search input on the page. If there is not, it displays the extra one. If there is, it puts the cursor in the existing one.

How does that sound?

@SidharthBansal
Copy link
Member

SidharthBansal commented Oct 22, 2018

Sounds great to me.

@prajwalkpatil
Copy link

where should the changes be made?
i am GCI- candidate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants