Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imageless spectrum graph doesn't undim if there are no tags #40

Open
jywarren opened this issue Jun 21, 2016 · 1 comment
Open

imageless spectrum graph doesn't undim if there are no tags #40

jywarren opened this issue Jun 21, 2016 · 1 comment

Comments

@jywarren
Copy link
Member

https://spectralworkbench.org/spectrums/78144 undims, and has no image, but one tag;

https://spectralworkbench.org/spectrums/80038 also has no image, and does not undim, and has no tags.

I forked 80038 and got https://spectralworkbench.org/spectrums/82180, which immediately had a "forked" tag, and did undim successfully.

Maybe the undim is only run after tags, and when there aren't any, it never runs?

Undim is here: https://github.com/publiclab/spectral-workbench.js/blob/master/src/SpectralWorkbench.Graph.js#L77

run on graph.refresh_and_reload()

@jywarren
Copy link
Member Author

Attempted a fix for this in v0.1.4, tested here: https://github.com/publiclab/spectral-workbench.js/blob/master/spec/javascripts/graph_spec.js#L88-L102 but test fails with opacity = '' instead of '1'... odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant