Push footer below map in /map/ #7048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstjean
force-pushed
the
map-include-footer
branch
from
33e7863
to
e997cd2
Compare
This was referenced Dec 26, 2019
|
This is what is happening when I use
|
|
How it looks with my overrides:
|
|
Yes it looks great! You can remove the testing data from this PR and this is ready to got then! |
Screenshots 📸 (click to expand)7048-test_questions.png7048-test_embeddable_grids.png7048-test_signup.png7048-test_viewing_the_settings_page.png7048-test_tag_by_author_page.png7048-test_wiki_page_with_inline_grids.png7048-test_stats.png7048-test_viewing_the_dashboard.png7048-test_searching_an_item_from_the_homepage.png7048-test_questions_shadow.png7048-test_login_modal.png7048-test_profile_page.png7048-test_comments.png7048-test_tags.png7048-test_signup_modal.png7048-test_wiki.png7048-test_methods.png7048-test_tag_page.png7048-test_blog_page_with_location_modal.png7048-test_tag_wildcard.png7048-test_embeddable_thumbnail_grids.png7048-test_front_page_with_navbar_search_autocomplete.png7048-test_login.png7048-test_viewing_the_dropdown_menu.png7048-test_viewing_question_post.png7048-test_mobile_displays.png7048-test_simple-data-grapher_powertag.png7048-test_front.png7048-test_question_page.png7048-test_tag_contributors_page.png7048-test_blog.png7048-test_people.png7048-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
|
@sagarpreet-chadha Removed the test data, this is all set to merge! |
nstjean
changed the title
cesswairimu
approved these changes
Jan 1, 2020
|
This is AWESOMEEEEEEEE |
Tlazypanda
pushed a commit
to Tlazypanda/plots2
that referenced
this pull request
Jan 14, 2020
* add footer content below map * make map fullwidth with css * remove test footer data
vinitshahdeo
pushed a commit
to vinitshahdeo/plots2
that referenced
this pull request
Feb 1, 2020
* add footer content below map * make map fullwidth with css * remove test footer data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7047 (<=== Add issue number here)
I tried using the class
inline-fullwidth-contentas suggested in #6993 but for some reason the map won't go full-width no matter what I do. I can get it to go full-width using other methods, but it would be awful nice to be able to use one standard class to achieve it!This currently has all kinds of footer info in layouts/_footer.html.erb just for testing purposes. I will remove it when I am done!