Remove coveralls, add codecov #5954

kaustubh-nair · 2019-06-27T08:56:42Z

Partially fixes #5931

codecov · 2019-06-27T09:32:20Z

Codecov Report

Merging #5954 into master will increase coverage by 6.08%.
The diff coverage is 81.88%.

@@            Coverage Diff             @@
##           master    #5954      +/-   ##
==========================================
+ Coverage   74.67%   80.75%   +6.08%     
==========================================
  Files          89       97       +8     
  Lines        5402     5561     +159     
==========================================
+ Hits         4034     4491     +457     
+ Misses       1368     1070     -298

Impacted Files	Coverage Δ
app/controllers/questions_controller.rb	`90.78% <ø> (+9.21%)`	⬆️
app/mailers/admin_mailer.rb	`100% <ø> (ø)`	⬆️
app/mailers/node_mailer.rb	`100% <ø> (ø)`	⬆️
app/helpers/search_helper.rb	`100% <ø> (ø)`	⬆️
app/controllers/comment_controller.rb	`87.23% <ø> (+14.89%)`	⬆️
app/models/node_tag.rb	`100% <100%> (ø)`	⬆️
app/models/doc_result.rb	`100% <100%> (ø)`	⬆️
app/controllers/subscription_controller.rb	`57% <100%> (+3.39%)`	⬆️
app/controllers/application_controller.rb	`92.37% <100%> (+8.73%)`	⬆️
app/helpers/csvfiles_helper.rb	`100% <100%> (ø)`
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60cbdaa...38e06f8. Read the comment docs.

kaustubh-nair · 2019-06-27T09:38:56Z

Rakefile

@@ -20,8 +20,6 @@ namespace :test do

  desc "Run rails and teaspoon tests"
  task :all => :environment do
-    require 'coveralls/rake/task'
-    Coveralls::RakeTask.new
    if ENV['GENERATE_REPORT'] == 'true'
      require 'ci/reporter/rake/test_unit'
      Rake::Task["ci:setup:testunit"].execute


@jywarren need some info on these tasks

kaustubh-nair · 2019-06-27T09:39:33Z

.travis.yml

+# - if [ $TASK != "rake test:all" ]; then
+#     echo -e '<?xml version="1.0" encoding="UTF-8"?>' > output.xml;
+#     tail -n +2 -q ./test/reports/TEST*.xml >> output.xml;
+#   fi


@jywarren @publiclab/reviewers What are these lines supposed to be doing? I'm not sure if they are related to coveralls or not

They're related to Coveralls, they generate the XML to be pushed to Coveralls. You can remove those.

Not sure about this. Dangerbot uses the xml too I think.

These were intended to search through standard formatted JUnit test reports and copy them into the Dangerbot comment in the PR. They broke some time ago, but were a really nice way to help people see where errors were occurring. I'd like to leave them in so we can fix them again some day!

kaustubh-nair · 2019-06-27T09:47:00Z

I've got codecov setup but the build is failing, because of some errors in the Rakefile I think
@jywarren Can you have a look?

jywarren · 2019-07-09T21:54:07Z

Ah, i think you'll have to remove Coveralls.push -


rake aborted!
Don't know how to build task 'coveralls:push' (See the list of available tasks with `rake --tasks`)
/app/Rakefile:29:in `block (2 levels) in <top (required)>'
/usr/local/bundle/gems/rake-12.3.2/exe/rake:27:in `<top (required)>'
Tasks: TOP => test:all
(See full trace by running task with --trace)
The command "docker-compose exec web bash -c "GENERATE_REPORT=true $TASK"" exited with 1.

Probably in the rakefile, line 29?

kaustubh-nair · 2019-07-10T05:53:37Z

Not sure why project check is turning up even though it's off. I guess it should be fine after merging?
@jywarren This is ready
Thanks!

kaustubh-nair · 2019-07-10T06:29:26Z

@jywarren On second thought, let's not merge this till I fix the inconsistencies on mapknitter. I might have to change the reporter

kaustubh-nair · 2019-07-11T09:53:05Z

@publiclab/reviewers Any idea why a unit test is failing? I haven't made changes to the code. That's weird. 😕

grvsachdeva · 2019-07-21T15:35:05Z

For sure, the error is not related to your code. I have restarted the job.

kaustubh-nair · 2019-07-21T18:25:27Z

We're facing the same coverage drop here too :/
I'm starting to think this a bug with Codecov itself and not an issue on our side

jywarren · 2019-08-03T06:45:07Z

Is the coverage drop consistent? I.e. if it's not related to code, are we seeing a non-deterministic behavior, perhaps resulting from the order of completion of tests, or from other branch tests getting mixed up somehow? Or is it showing the same exact drop each time this is run?

Can you open an issue on CodeCov's tracker and link between here and there to try to get some help on this? Thank you!

* typo replace omment with comment * Update blog.css * Update .travis.yml * Update .travis.yml * add codecov branch to travis for debugging

jywarren · 2019-12-29T16:26:19Z

Let's see how this does and then we can resolve conflicts and merge!

jywarren · 2020-01-01T16:36:21Z

@Uzay-G can you see why the tests didn't pass here? https://travis-ci.org/publiclab/plots2/builds/630645697?utm_source=github_status&utm_medium=notification

I restarted it after resolving conflicts but not sure why it had failed before. I hope it doesn't this time!

Uzay-G · 2020-01-01T20:24:13Z

I looked at it but don't understand why it bugged out then and worked now although nothing was changed. The error just says Mysql2::Error::ConnectionError: Can't connect to MySQL server on '127.0.0.1' (111 "Connection refused")

jywarren · 2020-01-02T17:18:01Z

Wow! This would increase our coverage to 80% then... Merging #5954 into master will increase coverage by 6.08%.

This would be awesome. Do you think it's ready to merge then?

From the chatroom:

@Uzay-G will try to take a look. it could just need to be restarted by closing and reopening... could be a random timeout

jywarren · 2020-01-02T17:18:42Z

Let's do this!!!

jywarren · 2020-01-02T17:20:49Z

🎉 🎉 🎉 🎉 🎉

Uzay-G · 2020-01-02T17:21:13Z

Nice! Yeah I think it's ready and it should work! 🎈 👍

Uzay-G · 2020-01-02T17:55:41Z

Ah! I don't understand why but for some reason the codecov bot is not commenting on new pull requests. This issue is really a mystery...

Uzay-G · 2020-01-02T18:08:53Z

Ok actually it worked but there is a problem. See here for what it did: #7086. It returns the error: exclamation No coverage uploaded for pull request base (master@e16e4bc).
I will try to fix it

Uzay-G · 2020-01-02T18:14:20Z

This is the error:

I think we need to edit the settings on the codecov dashboard so that the base is more recent maybe??
I'm not sure because I don't have permission to see the settings

jywarren · 2020-01-02T18:27:18Z

Ah, it's supposed to compare to the base that is the HEAD position of the master branch, not a static version, right?

…

On Thu, Jan 2, 2020 at 1:19 PM Uzay-G ***@***.***> wrote: This is the error: [image: codecov] <https://user-images.githubusercontent.com/52892257/71683845-f4e03c00-2d93-11ea-8a2b-01cbf4d7cfa4.png> I think we need to edit the settings on the codecov dashboard so that the base is more recent maybe?? I'm not sure because I don't have permission to see the settings — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#5954?email_source=notifications&email_token=AAAF6J5JED24A5PJ5R6JR4LQ3YVH3A5CNFSM4H3ZXL52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH67S4Q#issuecomment-570292594>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6J3AMMYGR4DIDWYICALQ3YVH3ANCNFSM4H3ZXL5Q> .

Uzay-G · 2020-01-02T18:28:30Z

Yeah it needs to compare to the base. What is it comparing to right now?
I don't think it will work with a static version

jywarren · 2020-01-02T18:52:56Z

I don't know, but is it potentially an issue that if tests haven't changed at all, then the PR doesn't meet the minimum requirement?

…

On Thu, Jan 2, 2020 at 1:33 PM Uzay-G ***@***.***> wrote: Yeah it needs to compare to the base. What is it comparing to right now? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#5954?email_source=notifications&email_token=AAAF6J3Q6PSWLUT7W2MA4F3Q3YW45A5CNFSM4H3ZXL52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH7AWRI#issuecomment-570297157>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6J6DFKUESFOMEUSYEA3Q3YW45ANCNFSM4H3ZXL5Q> .

Uzay-G · 2020-01-02T18:58:53Z

I don't think it's because of the pull request changes because all of the pull requests have the same message. The problem is that it is comparing to a commit that doesn't have a codecov report so it can't compare the changes.

Uzay-G · 2020-01-02T19:00:44Z

This page might help us: https://docs.codecov.io/docs/comparing-commits

Uzay-G · 2020-01-02T19:11:22Z

I think I know the problem and will try to fix it when I come back

jywarren · 2020-01-02T19:19:06Z

OK, awesome!

…

On Thu, Jan 2, 2020 at 2:11 PM Uzay-G ***@***.***> wrote: I think I know the problem and will try to fix it when I come back — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#5954?email_source=notifications&email_token=AAAF6J5RZ63G2XTY47ZQDZDQ3Y35XA5CNFSM4H3ZXL52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH7D4KY#issuecomment-570310187>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6J7TXKCIKYNLBLQ7MVTQ3Y35XANCNFSM4H3ZXL5Q> .

jywarren · 2020-01-02T20:56:28Z

Hi @Uzay-G (ref #5954) this is a good example PR: #6957

❗️ No coverage uploaded for pull request base (master@b701668). Click here to learn what that means.

Does this mean that as soon as we merge another PR to master, it'll have a recorded coverage base for that commit?

OH! You know what? What if squashing and merging is causing a new commit hash to be generated, and so we have to be sure tests are run on that too so that it files a coverage report for the newly generated squashed commit???

Uzay-G · 2020-01-02T21:29:03Z

Yeah maybe we need to merge one to have a base with a coverage report. I'm not sure what you mean by the second part bur merging one might be a good idea.

Uzay-G · 2020-01-02T21:30:38Z

We could merge #7076 to try it out

jywarren · 2020-01-02T22:19:27Z

OK i merged #7089

Let's look again. If it doesn't work, we can try merging WITHOUT squashing to test if that does not generate a different commit and so the coverage would be saved???

Uzay-G · 2020-01-02T22:52:27Z

It worked here: #5724 (comment). I think the issue is resolved!

Uzay-G · 2020-01-02T22:57:42Z

Since you merged the pr, codecov is working. Yay we fixed it! 🎂

jywarren · 2020-01-02T23:08:49Z

Ah! I think one complicating factor is that we are seeing it update progressively as the tests run...! We may just need to wait a bit longer.

…

On Thu, Jan 2, 2020 at 5:57 PM Uzay-G ***@***.***> wrote: Since you merged the pr, codecov is working. Yay we fixed it! 🎂 — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#5954?email_source=notifications&email_token=AAAF6J6OQJ6F7WEEGRPTAP3Q3ZWONA5CNFSM4H3ZXL52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH7W5XA#issuecomment-570388188>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6J5BGR5ESG5VSKT67PTQ3ZWONANCNFSM4H3ZXL5Q> .

Uzay-G · 2020-01-02T23:12:34Z

Yeah I agree

* Remove coveralls, add codecov * Add env variable * Comment reporting lines * Change env variable * Remove coveralls from rake file * Fix travis and rakefile * Remove project for codecov * Remove old reports before running * typo replace omment with comment (publiclab#7042) * typo replace omment with comment * Update blog.css * Update .travis.yml * Update .travis.yml * add codecov branch to travis for debugging Co-authored-by: Uzay-G <[email protected]> Co-authored-by: Jeffrey Warren <[email protected]>

kaustubh-nair added 4 commits June 27, 2019 14:25

Remove coveralls, add codecov

f747a25

Add env variable

d3ea058

Comment reporting lines

9936f50

Change env variable

be11a7d

Remove coveralls from rake file

4bb814e

kaustubh-nair commented Jun 27, 2019

View reviewed changes

kaustubh-nair added 2 commits July 10, 2019 11:01

Fix travis and rakefile

6ec82b0

Remove project for codecov

0a7779a

kaustubh-nair mentioned this pull request Jul 10, 2019

Weekly community Check-In #28 - Teamwork publiclab/leaflet-environmental-layers#231

Closed

Remove old reports before running

bbe08b5

grvsachdeva added the in progress label Jul 21, 2019

jywarren mentioned this pull request Sep 13, 2019

Resolve coverage reporting issues with CodeCov #6290

Open

typo replace omment with comment (#7042)

60cbdaa

* typo replace omment with comment * Update blog.css * Update .travis.yml * Update .travis.yml * add codecov branch to travis for debugging

Merge branch 'master' into codecov

38e06f8

jywarren approved these changes Jan 2, 2020

View reviewed changes

jywarren merged commit 00f071e into master Jan 2, 2020

jywarren mentioned this pull request Jan 2, 2020

Fix map on profile and add check for zoom tag #7089

Merged

jywarren mentioned this pull request Jul 13, 2021

Periodic test failures in GitHub Actions CI and CodeCov #9873

Closed

Remove coveralls, add codecov #5954

Remove coveralls, add codecov #5954

Conversation

kaustubh-nair commented Jun 27, 2019 • edited Loading

codecov bot commented Jun 27, 2019 • edited Loading

Codecov Report

kaustubh-nair Jun 27, 2019

Choose a reason for hiding this comment

kaustubh-nair Jun 27, 2019

Choose a reason for hiding this comment

alaxalves Jun 29, 2019

Choose a reason for hiding this comment

kaustubh-nair Jun 30, 2019

Choose a reason for hiding this comment

jywarren Jul 9, 2019

Choose a reason for hiding this comment

kaustubh-nair commented Jun 27, 2019

jywarren commented Jul 9, 2019

kaustubh-nair commented Jul 10, 2019

kaustubh-nair commented Jul 10, 2019

kaustubh-nair commented Jul 11, 2019

grvsachdeva commented Jul 21, 2019

kaustubh-nair commented Jul 21, 2019

jywarren commented Aug 3, 2019

jywarren commented Dec 29, 2019

jywarren commented Jan 1, 2020

Uzay-G commented Jan 1, 2020

jywarren commented Jan 2, 2020

jywarren commented Jan 2, 2020

jywarren commented Jan 2, 2020

Uzay-G commented Jan 2, 2020

Uzay-G commented Jan 2, 2020

Uzay-G commented Jan 2, 2020

Uzay-G commented Jan 2, 2020

jywarren commented Jan 2, 2020 via email

Uzay-G commented Jan 2, 2020 • edited Loading

jywarren commented Jan 2, 2020 via email

Uzay-G commented Jan 2, 2020

Uzay-G commented Jan 2, 2020

Uzay-G commented Jan 2, 2020

jywarren commented Jan 2, 2020 via email

jywarren commented Jan 2, 2020

Uzay-G commented Jan 2, 2020

Uzay-G commented Jan 2, 2020

jywarren commented Jan 2, 2020

Uzay-G commented Jan 2, 2020

Uzay-G commented Jan 2, 2020

jywarren commented Jan 2, 2020 via email

Uzay-G commented Jan 2, 2020

kaustubh-nair commented Jun 27, 2019 •

edited

Loading

codecov bot commented Jun 27, 2019 •

edited

Loading

Uzay-G commented Jan 2, 2020 •

edited

Loading