Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove datepicker if a page already has a date tag #9517

Closed
5 tasks
TildaDares opened this issue Apr 16, 2021 · 17 comments · Fixed by #9530
Closed
5 tasks

Remove datepicker if a page already has a date tag #9517

TildaDares opened this issue Apr 16, 2021 · 17 comments · Fixed by #9530
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute HTML

Comments

@TildaDares
Copy link
Member

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/views/notes/show.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -91,7 +91,11 @@
       current_user.id == @node.id || current_user.is_coauthor?(@node) ) && 
       @node.has_tag('event') %>
   <hr/>
-  <p>This looks like an event.     <span><button id="date-toggle" class="btn-outline-secondary btn-sm" data-toggle="tooltip" data-placement="right" title="Add Date"><i class="fa fa-calendar" aria-hidden="true"></i></button></span></p>
+  <p>This looks like an event.  
+    <% unless @node.has_power_tag('date') %>
+      <span><button id="date-toggle" class="btn-outline-secondary btn-sm" data-toggle="tooltip" data-placement="right" title="Add Date"><i class="fa fa-calendar" aria-hidden="true"></i></button></span>
+    <% end %>
+  </p>
   <div id="event-datepicker">
     <input type="text" class="datepicker" aria-describedby="DatePickerGuide"/>
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@TildaDares TildaDares added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Apr 16, 2021
@TildaDares
Copy link
Member Author

@cesswairimu

@VarunAroraCode
Copy link
Contributor

Hi, I'm working on an open source class project and would like to contribute! Can I be assigned this issue?

@TildaDares
Copy link
Member Author

@VarunAroraCode A reviewer has to give their okay before you start working on this. @cesswairimu Is this FTO okay?

@RuthNjeri
Copy link
Contributor

@TildaDares, can you share an image showing what happens now and what happens after the changes suggested in the issue?

@TildaDares
Copy link
Member Author

TildaDares commented Apr 18, 2021

Before

image

After

image

@RuthNjeri

@VarunAroraCode
Copy link
Contributor

@TildaDares Any idea when that would be possible? I'd love to finish this up by the end of the day

@TildaDares
Copy link
Member Author

@VarunAroraCode Sorry, this isn't up to me.

@VarunAroraCode
Copy link
Contributor

@TildaDares I understand. Thanks for tagging who is!

@jywarren
Copy link
Member

This looks great! Let's go for it!!! (i'm a reviewer ❤️ )

@jywarren jywarren added help wanted requires help by anyone willing to contribute HTML labels Apr 19, 2021
@VarunAroraCode
Copy link
Contributor

Awesome! I'll get started (and hopefully finish) asap!

@DR-FREKE
Copy link
Contributor

can I also be a contributor on this? @VarunAroraCode @jywarren @TildaDares @cesswairimu . Thank you

@TildaDares
Copy link
Member Author

@DR-FREKE Only one person can work an issue but if @VarunAroraCode is no longer working on it then you can take it up.

@DR-FREKE
Copy link
Contributor

@TildaDares ok but how do I know that?

@TildaDares
Copy link
Member Author

TildaDares commented Apr 23, 2021

@DR-FREKE When I see a good-first-issue I'll let you know.

@cesswairimu
Copy link
Collaborator

@DR-FREKE also adding your name here #9083 . Thanks everyone

@Manasa2850 Manasa2850 mentioned this issue Apr 25, 2021
5 tasks
@Manasa2850
Copy link
Member

@cesswairimu I've updated the issue number in #9530. I think it can be merged.
Thanks everyone!

@cesswairimu
Copy link
Collaborator

Thanks @Manasa2850 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute HTML
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants