Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language attribute to the html start tag #1662

Closed
10 tasks
on2onyekachi opened this issue Apr 21, 2022 · 14 comments · Fixed by #1754
Closed
10 tasks

Add language attribute to the html start tag #1662

on2onyekachi opened this issue Apr 21, 2022 · 14 comments · Fixed by #1754

Comments

@on2onyekachi
Copy link

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

- <html> 
+ <html lang="en">
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below, and reach out in our chatroom!

@welcome
Copy link

welcome bot commented Apr 21, 2022

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄
If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

@TildaDares
Copy link
Member

Thanks @on2onyekachi. This looks good!!

@TildaDares
Copy link
Member

Reserved for @Pragati1419 for 24 hours!

@Pragati1419
Copy link

@TildaDares thank you mam for opening this issue to me

@AndresCarignano
Copy link

Hi can I try it out?

@BioMeindinyo
Copy link

Hi @Pragati1419, have you been able to solve the issue already?

@shahern004
Copy link

Trying to fix this

@PlusUltra404
Copy link

@TildaDares Hello, Would I be able to work on this also. I am a FT.

@TildaDares
Copy link
Member

Hi @shahern004, are you still working on this? If you need help, please feel free to reach out.

@PlusUltra404 While we wait for @shahern004’s response, you can request for an issue in publiclab/plots2#11105 and we’ll ping once we have one ready for you. Thanks!!

@TildaDares
Copy link
Member

Reserved for @istarlet for 24 hours!!

@istarlet
Copy link

I hope I did this correctly. Please review when you are able!

@TildaDares
Copy link
Member

Reserved for @matthewjholmes for 24 hours!

@TildaDares
Copy link
Member

Please remember to add the changes in all 5 files in a single PR.

@matthewjholmes
Copy link
Contributor

Great--I'll get to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants