Add test mock for google api geocoder #358
Conversation
| @@ -3,7 +3,7 @@ | |||
| <head> | |||
| <meta charset="utf-8"> | |||
| <title>Jasmine Spec Runner</title> | |||
| <link rel="shortcut icon" type="image/png" href=".grunt\grunt-contrib-jasmine\jasmine_favicon.png"> | |||
There was a problem hiding this comment.
This file should be generated on run-time ideally, but let it be there.
There was a problem hiding this comment.
That's weird that it changed that line, I didn't touch that file. I don't think this file exists in LBLD, I wonder if it's actually using it at all? The jasmine.json file existed but was totally ignored by Jasmine.
There was a problem hiding this comment.
Yes I was right... I can delete that file and it doesn't affect the tests at all. It is being generated at runtime.
There was a problem hiding this comment.
Which is to say, it gets re-generated at runtime.
| @@ -52,7 +52,7 @@ | |||
| "dependencies": { | |||
| "jquery": "^3.3.1", | |||
| "leaflet": "^1.3.1", | |||
| "leaflet-blurred-location": "git://github.com/publiclab/leaflet-blurred-location#main", | |||
| "leaflet-blurred-location": "git://github.com/publiclab/leaflet-blurred-location.git#main", | |||
| "leaflet-fullhash": "github:sagarpreet-chadha/leaflet-fullHash", | |||
There was a problem hiding this comment.
Which one, leaflet-fullhash?
There was a problem hiding this comment.
Yes, It is not used in LEL anymore.
|
This may no longer be needed, see my comment on publiclab/leaflet-blurred-location#235 (comment) |
|
This is no longer needed after publiclab/leaflet-blurred-location#235 |
Fixes #357 (<=== Add issue number here)
This is the same fix as in LBLD publiclab/leaflet-blurred-location-display#93