Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore stop_timezone when calculating arrivals/departures #38

Merged
merged 1 commit into from
Aug 2, 2023
Merged

ignore stop_timezone when calculating arrivals/departures #38

merged 1 commit into from
Aug 2, 2023

Conversation

derhuerst
Copy link
Member

@derhuerst derhuerst commented Mar 30, 2023 •
edited
Loading

@derhuerst derhuerst self-assigned this Mar 30, 2023
@derhuerst derhuerst force-pushed the ignore-stop-timezone branch 2 times, most recently from 085e203 to c3decaa Compare April 7, 2023 13:20
@derhuerst derhuerst marked this pull request as ready for review April 7, 2023 13:22
derhuerst referenced this pull request in motis-project/nigiri Apr 11, 2023
@felixguendling
GTFS-static support (#26)
60d256a
@felixguendling felixguendling mentioned this pull request Apr 11, 2023
Closed
@derhuerst
Copy link
Member Author

google/transit#378 is now merged, so this PR can be merged too.

@derhuerst
ignore stop_timezone when calculating arrivals/departures 🐛✅
7615102 
Apparently, stop_timezone was only ever intended for displaying local date+time.
The current operating practice has been clarified in google/transit#322.
@derhuerst derhuerst merged commit 7615102 into main Aug 2, 2023
5 checks passed
@derhuerst derhuerst deleted the ignore-stop-timezone branch August 2, 2023 10:40
@derhuerst
Copy link
Member Author

Published as [email protected]. 🎉

@derhuerst
Copy link
Member Author

It seems like this change also speeds up most stop_times-based operations:

query 4.7.3 avg 4.7.3 p50 4.7.3 p95 4.7.3 iterations 4.7.4 avg 4.7.4 p50 4.7.4 p95 4.7.4 iterations 
SELECT *
FROM arrivals_departures
WHERE route_short_name = 'S1'
AND t_departure >= '2022-08-09T07:10+02' AND t_departure <= '2022-08-09T07:30+02'
AND date >= dates_filter_min('2022-08-09T07:10+02')
AND date <= dates_filter_max('2022-08-09T07:30+02')
 62 62 62 100 61 61 61 100 
SELECT *
FROM arrivals_departures
WHERE station_id = 'de:11000:900100001' -- S+U Friedrichstr. (Berlin)
AND t_departure >= '2022-08-09T07:10+02' AND t_departure <= '2022-08-09T07:30+02'
AND date >= dates_filter_min('2022-08-09T07:10+02')
AND date <= dates_filter_max('2022-08-09T07:30+02')
 34 34 34 40 33 33 33 40 
SELECT *
FROM arrivals_departures
WHERE station_id = 'de:11000:900100001' -- S+U Friedrichstr. (Berlin)
AND t_departure >= '2022-08-09T07:10+02' AND t_departure <= '2022-08-09T07:30+02'
AND date >= dates_filter_min('2022-08-09T07:10+02')
AND date <= dates_filter_max('2022-08-09T07:30+02')
AND stop_sequence = 0
 4 4 4 50 5 5 5 50 
SELECT *
FROM arrivals_departures
WHERE stop_id = 'de:11000:900100001::4' -- S+U Friedrichstr. (Berlin)
AND t_departure >= '2022-08-09T07:10+02' AND t_departure <= '2022-08-09T07:30+02'
AND date >= dates_filter_min('2022-08-09T07:10+02')
AND date <= dates_filter_max('2022-08-09T07:30+02')
 7 7 7 100 8 8 8 100 
SELECT *
FROM arrivals_departures
WHERE trip_id = '168977951'
AND date > '2022-08-08' AND date <= '2022-08-09'
 2 2 2 100 2 2 2 100 
SELECT count(*)
FROM arrivals_departures
WHERE stop_id = 'de:11000:900100001::4' -- S+U Friedrichstr. (Berlin)
 58 58 58 100 58 58 58 100 
SELECT count(*)
FROM arrivals_departures
WHERE stop_id = 'definitely-non-existent'
 2 2 2 100 2 2 2 100 
SELECT *
FROM arrivals_departures
WHERE t_departure >= '2022-08-09T07:10+02' AND t_departure <= '2022-08-09T07:30+02'
AND date >= dates_filter_min('2022-08-09T07:10+02'::timestamp with time zone)
AND date <= dates_filter_max('2022-08-09T07:30+02'::timestamp with time zone)
 6250 6247 6280 10 6310 6262 6503 10 
SELECT *
FROM arrivals_departures
WHERE t_departure >= '2022-08-09T07:10+02' AND t_departure <= '2022-08-09T07:30+02'
AND date >= '2022-08-08'
AND date <= '2022-08-09'
 3059 3062 3116 10 4931 4928 4946 10 
SELECT *
FROM connections
WHERE route_short_name = 'S1'
AND t_departure >= '2022-08-09T07:10+02' AND t_departure <= '2022-08-09T07:30+02'
AND date >= dates_filter_min('2022-08-09T07:10+02')
AND date <= dates_filter_max('2022-08-09T07:30+02')
 175 171 194 100 164 164 164 100 
SELECT *
FROM connections
WHERE from_station_id = 'de:11000:900100001' -- S+U Friedrichstr. (Berlin)
AND t_departure >= '2022-08-09T07:10+02' AND t_departure <= '2022-08-09T07:30+02'
AND date >= dates_filter_min('2022-08-09T07:10+02')
AND date <= dates_filter_max('2022-08-09T07:30+02')
 61 61 61 40 59 58 60 40 
SELECT *
FROM connections
WHERE from_station_id = 'de:11000:900100001' -- S+U Friedrichstr. (Berlin)
AND t_departure >= '2022-08-09T07:10+02' AND t_departure <= '2022-08-09T07:30+02'
AND date >= dates_filter_min('2022-08-09T07:10+02')
AND date <= dates_filter_max('2022-08-09T07:30+02')
AND from_stop_sequence = 0
 7 7 7 50 7 7 7 50 
SELECT *
FROM connections
WHERE from_stop_id = 'de:11000:900100001::4' -- S+U Friedrichstr. (Berlin)
AND t_departure >= '2022-08-09T07:10+02' AND t_departure <= '2022-08-09T07:30+02'
AND date >= dates_filter_min('2022-08-09T07:10+02')
AND date <= dates_filter_max('2022-08-09T07:30+02')
 14 14 14 100 15 15 15 100 
SELECT *
FROM connections
WHERE trip_id = '168977951'
AND date > '2022-08-08' AND date <= '2022-08-09'
 3 3 3 100 3 3 3 100 
SELECT count(*)
FROM connections
WHERE from_stop_id = 'de:11000:900100001::4' -- S+U Friedrichstr. (Berlin)
 74 73 77 100 73 73 73 100 
SELECT count(*)
FROM connections
WHERE from_stop_id = 'definitely-non-existent'
 3 3 3 100 3 3 3 100 
SELECT *
FROM connections
WHERE t_departure >= '2022-08-09T07:10+02' AND t_departure <= '2022-08-09T07:30+02'
AND date >= dates_filter_min('2022-08-09T07:10+02'::timestamp with time zone)
AND date <= dates_filter_max('2022-08-09T07:30+02'::timestamp with time zone)
ORDER BY t_departure
LIMIT 100
 16645 16633 16906 7 13127 13125 13194 7 
SELECT *
FROM connections
WHERE t_departure >= '2022-08-09T07:10+02' AND t_departure <= '2022-08-09T07:30+02'
AND date >= '2022-08-08'
AND date <= '2022-08-09'
ORDER BY t_departure
LIMIT 100
 11411 11408 11788 7 6417 6394 6562 7 
SELECT *
FROM stats_by_route_date
WHERE route_id = '17452_900' -- M4
AND date >= '2022-08-08' AND date <= '2022-08-14'
AND is_effective = true
 3630 3628 3644 10 2862 2863 2867 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@derhuerst derhuerst

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@derhuerst