Skip to content
This repository has been archived by the owner on Aug 27, 2023. It is now read-only.

Slow build with massive memory consumption #22

Open
gnadrian opened this issue Jun 8, 2023 · 2 comments
Open

Slow build with massive memory consumption #22

gnadrian opened this issue Jun 8, 2023 · 2 comments

Comments

@gnadrian
Copy link

gnadrian commented Jun 8, 2023

Hi, nice project, but it takes me 127 seconds to build, and memory usage is through the roof while building (see attached screenshot). This on a Macbook Pro M1 Pro with 32GB – i.e. a decent machine.

Presumably this is a failing of the Swift compiler, but have you thought about restructuring your code in some way to try and avoid this?

Screenshot 2023-06-09 at 10 29 48 AM
@ptrkstr
Copy link
Owner

ptrkstr commented Jun 16, 2023

Hey @gnadrian, thanks for reaching out 👋
You raise a good point; the build optimisation could be improved, maybe through storing the information in CoreData.
However I currently don't utilise this package in my projects so don't have the time to work on it.

@ptrkstr
Copy link
Owner

ptrkstr commented Jun 16, 2023

@gnadrian it's possible that this PR was the cause of it due to it introducing a huge dictionary for fast lookup.
https://github.com/ptrkstr/Devices/pull/17/files#diff-509adb9d11c9bcc8e141438d4a0e540a08c21527ead128dc1f1b2ecf913583ce

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants