Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Docker Config for Secret Vars only if the variables were changed #110

Closed
bohdan-shulha opened this issue Aug 9, 2024 · 1 comment
Labels
Milestone

Comments

@bohdan-shulha
Copy link
Contributor

bohdan-shulha commented Aug 9, 2024

We can not access the value of the secret variables, but we can access their names.

Need to compare "previous" and "current" set of the variables and if these set match and no new values are provided - reuse the previous config.

We can consider dropping the configs creation for secret vars, as they are applied as env vars on the container anyway.

Looks like we might not need to create docker configs to persist this data at all, as, if a user would need to restore the previous state, secrets will be there. See encryption ticket for details: #17

@bohdan-shulha bohdan-shulha added this to the Post-MVP milestone Aug 9, 2024
@github-actions github-actions bot added the triage label Aug 9, 2024
@bohdan-shulha bohdan-shulha modified the milestones: Alpha, Beta Aug 29, 2024
@bohdan-shulha
Copy link
Contributor Author

Not needed anymore - there are no "secret vars configs" ptah-sh/ptah-agent#51

@bohdan-shulha bohdan-shulha closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant