-
-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add support for Python 3.12 macOS arm64 wheels #1638
chore: add support for Python 3.12 macOS arm64 wheels #1638
Conversation
Uhm... that's weird, I was sure we had released arm64 macos wheels... but
they seem missing from pypi indeed.
I'll look into it later. Thank you for the report and for the chores.
|
I'm waiting for a Scaleway machine to get free to make a macOS arm64 build. |
I have Apple Silicon, is it possible for you to build remotely on my machine? |
scripts/build/build_macos_arm64.sh
Outdated
@@ -89,7 +89,7 @@ log "building wheels" | |||
# Build the binary packages | |||
export CIBW_PLATFORM=macos | |||
export CIBW_ARCHS=arm64 | |||
export CIBW_BUILD='cp{38,39,310,311}-*' | |||
export CIBW_BUILD='cp{38,39,310,311,312}-*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is the part I had forgotten, sorry about that.
I managed to get a builder. Packages on the way.
I have cherry-picked your change, thank you very much. Missing package released on pypi. |
Why was a simple merge not possible? Now it looks like this PR has been closed unmerged, but the changes were introduced anyway, very confusing for future contributors lol |
37b9d57
to
941ac9a
Compare
Your MR was based on master, but because we needed to package 2.9.9 it should have departed from the tag. So I cherry-picked in a branch from there, built the packages, and merged. The alternative would have to force-push in this branch. I tried to do it now, re-opening and pushing, but the MR got "closed" again. I seem to remember it would have been merged. It is the first time that someone asks me to have their MR status on github "right". Why? Does anyone keep the stats? For me github is just a web interface and we may decide to go somewhere else sometimes. What matters, for me, is the git history, and cherry-picking it maintains the attribution of your work:
For me, for instance, you should have set your email better. Now you will go down in the history as "random number @ noreply" 😛 |
By the way, just to make it clear: I am very grateful for your contribution and should you contribute more in the future I will try to remember the workflow of force-pushing and merging rather than cherry-picking. |
I tried to install psycopg2-binary... and failed, that's a first 😅
So I added the missing 3.12 wheels and updated python_versions to the latest releases.