Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.php is under git control #90

Closed
dereks opened this issue Jan 21, 2017 · 1 comment
Closed

config.php is under git control #90

dereks opened this issue Jan 21, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@dereks
Copy link
Contributor

dereks commented Jan 21, 2017

Initial setup requires copying two .js files:

  1. filemanager.config.default.json -> filemanager.config.json
  2. filemanager.init.js.example -> filemanager.init.js

(Optionally, the copied files can be edited to set custom options.)

The copied files show up as untracked files in git, which is a little annoying, but it is easy to ignore and it could be easily fixed by adding them to the .gitignore file. So, the .js config files are cool.

In contrast, if using PHP, the user must also edit this file:

  1. connectors/php/config.php -> edited to change fileRoot from false to a valid path on the system.

This is a problem because, in order to run this code during development, I must edit config.php. But now, every time I try to do a git commit or branch change, git notices that config.php has changed and it asks me to take action. This is especially annoying when changing branches, because the developer must "stash" the change to config.php, checkout the new branch, then "stash apply" the config change back.

I propose fixing this so that config.php (and other connector config files) are treated like the .js files. It should be controlled by git as filename config.default.php, and then the user copies it to config.php and edits it. Then config.php can even be added to the .gitignore file so it doesn't show up as a (mildly annoying) untracked file.

If @servocoder agrees with this approach I will submit a Pull Request to the dev branch. (There are other ways to address config files in git, but I think this is the easiest.)

Unfortunately, the Wiki docs will need to be updated to reflect this additional file copy during setup. (I am happy to make the documentation edits but I don't have write access to the project Wiki.)

Thanks!

dereks added a commit to dereks/RichFilemanager that referenced this issue Feb 9, 2017
@psolom psolom added this to the 2.4.0 milestone May 6, 2017
@psolom psolom self-assigned this May 6, 2017
@psolom psolom added the question label May 6, 2017
@psolom
Copy link
Owner

psolom commented May 7, 2017

PHP connector's config files are part of a separate package now, that is located at the https://github.com/servocoder/RichFilemanager-PHP repository. Config files are not supposed to be replaced, but the options could be extended upon application initiation at the entry point script: https://github.com/servocoder/RichFilemanager-PHP#entry-point-setup

@psolom psolom closed this as completed May 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants