Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Connector: ZIP download (option: allowFolderDownload) requires the folder to be writable #130

Closed
dereks opened this issue Mar 21, 2017 · 2 comments
Assignees
Milestone

Comments

@dereks
Copy link
Contributor

dereks commented Mar 21, 2017

The PHP connector requires that a target folder be writable, in order to allow it to be downloaded as a ZIP. There is no reason for this. If I can read a dir, I should be able to read it as a convenient ZIP download. (The ZIP file itself is generated and written into /tmp/, which is writable for everyone.)

The error is in LocalFilemanager.php:874

		// check if file is writable
		if(!$this->has_system_permission($target_fullpath, ['w'])) {
			$this->error(sprintf($this->lang('NOT_ALLOWED_SYSTEM')));
		}

(I discovered this while working on the allowFolderDownload option.)

Feel free to assign this issue to me. I am in the middle of config option updates and can fix this when that is done.

@psolom
Copy link
Owner

psolom commented Mar 21, 2017

Nice catch. I have assigned it to you. Thanks.

@psolom psolom added this to the 2.4.0 milestone Apr 1, 2017
@psolom psolom assigned psolom and dereks and unassigned dereks May 6, 2017
@psolom
Copy link
Owner

psolom commented May 7, 2017

Fix included into the v2.4.0 release

@psolom psolom closed this as completed May 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants