From 35b9bfa3c76e0afbedd1da0bfc774fda67a2ed14 Mon Sep 17 00:00:00 2001 From: Alex Langenfeld Date: Wed, 4 Dec 2024 13:02:30 -0600 Subject: [PATCH] protobuf ceiling bump (#26271) resolves https://github.com/dagster-io/dagster/issues/25398 ## How I Tested These Changes existing coverage --- python_modules/dagster/setup.py | 4 ++-- python_modules/libraries/dagster-mlflow/setup.py | 7 ++++++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/python_modules/dagster/setup.py b/python_modules/dagster/setup.py index 0e99075c46176..62c5322540faf 100644 --- a/python_modules/dagster/setup.py +++ b/python_modules/dagster/setup.py @@ -87,8 +87,8 @@ def get_version() -> str: f"grpcio>={GRPC_VERSION_FLOOR}", f"grpcio-health-checking>={GRPC_VERSION_FLOOR}", "packaging>=20.9", - "protobuf>=3.20.0,<5; python_version<'3.11'", # min protobuf version to be compatible with both protobuf 3 and 4 - "protobuf>=4,<5; python_version>='3.11'", + "protobuf>=3.20.0,<6; python_version<'3.11'", # min protobuf version to be compatible with both protobuf 3 and greater + "protobuf>=4,<6; python_version>='3.11'", "python-dotenv", "pytz", "requests", diff --git a/python_modules/libraries/dagster-mlflow/setup.py b/python_modules/libraries/dagster-mlflow/setup.py index 1d7dc2ed21dff..b95fa88657bf4 100644 --- a/python_modules/libraries/dagster-mlflow/setup.py +++ b/python_modules/libraries/dagster-mlflow/setup.py @@ -32,6 +32,11 @@ def get_version() -> str: packages=find_packages(exclude=["dagster_mlflow_tests*"]), include_package_data=True, python_requires=">=3.9,<3.13", - install_requires=[f"dagster{pin}", "mlflow", "pandas"], + install_requires=[ + f"dagster{pin}", + "mlflow", + "pandas", + "protobuf!=5.29.0", # https://github.com/protocolbuffers/protobuf/issues/19430 + ], zip_safe=False, )