Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.12.10: test suite is using lockfile #273

Closed
kloczek opened this issue Jan 5, 2022 · 4 comments
Closed

0.12.10: test suite is using lockfile #273

kloczek opened this issue Jan 5, 2022 · 4 comments

Comments

@kloczek
Copy link

kloczek commented Jan 5, 2022

Looks like test suite is using lockfile module which is no longer maintained (since 2015).
https://pypi.org/project/lockfile/#history
https://github.com/openstack-archive/pylockfile/
I'm not sure what could be used instead ..

@kloczek
Copy link
Author

kloczek commented Jan 18, 2022

I;ve been trying to package lockfile and build and pytest shows that probably soon it will be not possible to use it (when python 3.11 will be released)

+ /usr/bin/python3 -sBm build -w --no-isolation
* Getting dependencies for wheel...
/usr/lib/python3.8/site-packages/setuptools/dist.py:723: UserWarning: Usage of dash-separated 'description-file' will not be supported in future versions. Please use the underscore name 'description_file' instead
  warnings.warn(
/usr/lib/python3.8/site-packages/setuptools/dist.py:723: UserWarning: Usage of dash-separated 'author-email' will not be supported in future versions. Please use the underscore name 'author_email' instead
  warnings.warn(
/usr/lib/python3.8/site-packages/setuptools/dist.py:723: UserWarning: Usage of dash-separated 'home-page' will not be supported in future versions. Please use the underscore name 'home_page' instead
  warnings.warn(
* Building wheel...
/usr/lib/python3.8/site-packages/setuptools/command/easy_install.py:157: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
/usr/lib/python3.8/site-packages/setuptools/dist.py:723: UserWarning: Usage of dash-separated 'description-file' will not be supported in future versions. Please use the underscore name 'description_file' instead
  warnings.warn(
/usr/lib/python3.8/site-packages/setuptools/dist.py:723: UserWarning: Usage of dash-separated 'author-email' will not be supported in future versions. Please use the underscore name 'author_email' instead
  warnings.warn(
/usr/lib/python3.8/site-packages/setuptools/dist.py:723: UserWarning: Usage of dash-separated 'home-page' will not be supported in future versions. Please use the underscore name 'home_page' instead
  warnings.warn(
running bdist_wheel
running build
running build_py
creating build
creating build/lib
creating build/lib/lockfile
copying lockfile/pidlockfile.py -> build/lib/lockfile
copying lockfile/symlinklockfile.py -> build/lib/lockfile
copying lockfile/sqlitelockfile.py -> build/lib/lockfile
copying lockfile/mkdirlockfile.py -> build/lib/lockfile
copying lockfile/__init__.py -> build/lib/lockfile
copying lockfile/linklockfile.py -> build/lib/lockfile
running egg_info
running install
running install_lib
creating build/bdist.linux-x86_64
creating build/bdist.linux-x86_64/wheel
creating build/bdist.linux-x86_64/wheel/lockfile
running install_egg_info
Copying lockfile.egg-info to build/bdist.linux-x86_64/wheel/lockfile-0.12.2-py3.8.egg-info
running install_scripts
Successfully built lockfile-0.12.2-py2.py3-none-any.whl

[..]

+ PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-lockfile-0.12.2-5.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-lockfile-0.12.2-5.fc35.x86_64/usr/lib/python3.8/site-packages
+ /usr/bin/pytest -ra test/compliancetest.py test/test_lockfile.py
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.8.12, pytest-6.2.5, py-1.11.0, pluggy-1.0.0
rootdir: /home/tkloczko/rpmbuild/BUILD/lockfile-0.12.2
collected 0 items

============================================================================= warnings summary =============================================================================
test/test_lockfile.py:9
  /home/tkloczko/rpmbuild/BUILD/lockfile-0.12.2/test/test_lockfile.py:9: PytestCollectionWarning: cannot collect test class 'TestLinkLockFile' because it has a __init__ constructor (from: test/test_lockfile.py)
    class TestLinkLockFile(ComplianceTest):

test/test_lockfile.py:13
  /home/tkloczko/rpmbuild/BUILD/lockfile-0.12.2/test/test_lockfile.py:13: PytestCollectionWarning: cannot collect test class 'TestSymlinkLockFile' because it has a __init__ constructor (from: test/test_lockfile.py)
    class TestSymlinkLockFile(ComplianceTest):

test/test_lockfile.py:17
  /home/tkloczko/rpmbuild/BUILD/lockfile-0.12.2/test/test_lockfile.py:17: PytestCollectionWarning: cannot collect test class 'TestMkdirLockFile' because it has a __init__ constructor (from: test/test_lockfile.py)
    class TestMkdirLockFile(ComplianceTest):

test/test_lockfile.py:21
  /home/tkloczko/rpmbuild/BUILD/lockfile-0.12.2/test/test_lockfile.py:21: PytestCollectionWarning: cannot collect test class 'TestPIDLockFile' because it has a __init__ constructor (from: test/test_lockfile.py)
    class TestPIDLockFile(ComplianceTest):

test/test_lockfile.py:26
  /home/tkloczko/rpmbuild/BUILD/lockfile-0.12.2/test/test_lockfile.py:26: PytestCollectionWarning: cannot collect test class 'TestLinkFileLock' because it has a __init__ constructor (from: test/test_lockfile.py)
    class TestLinkFileLock(ComplianceTest):

test/test_lockfile.py:30
  /home/tkloczko/rpmbuild/BUILD/lockfile-0.12.2/test/test_lockfile.py:30: PytestCollectionWarning: cannot collect test class 'TestMkdirFileLock' because it has a __init__ constructor (from: test/test_lockfile.py)
    class TestMkdirFileLock(ComplianceTest):

test/test_lockfile.py:40
  /home/tkloczko/rpmbuild/BUILD/lockfile-0.12.2/test/test_lockfile.py:40: PytestCollectionWarning: cannot collect test class 'TestSQLiteLockFile' because it has a __init__ constructor (from: test/test_lockfile.py)
    class TestSQLiteLockFile(ComplianceTest):

-- Docs: https://docs.pytest.org/en/stable/warnings.html
=========================================================================== 7 warnings in 0.04s ============================================================================

https://github.com/openstack-archive/pylockfile suggests use fasteners https://github.com/harlowja/fasteners

@kloczek
Copy link
Author

kloczek commented Jan 18, 2022

Just found that actually someone started working on that #114

@zanieb
Copy link

zanieb commented Sep 14, 2022

@frostming
Copy link
Contributor

This is closed by #284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants