-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a --single-quotes option to prefer single quotes #633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I find double quotes easier to type on my keyboard layout, but here's some typos)
ccd0797
to
bd6e829
Compare
Add support for `black -s|--single-quotes`. Fixes psf#594
Thank you for your contribution but we won't be adding this to Black. |
Support for this has been added to https://github.com/odwyersoftware/brunette 👍 |
Could the brunette --single-quotes be imported to black? |
Is there any explanation as to why this option not being added? Your main page says,
Actually, after using your tool, I don't have any time and mental energy left at all, because I use single quotes everywhere, as they are easier to type on my keyboard. |
Not sure I understand why you feel this is an issue, @y4rr. After all, since |
This feels really strange. Why not allow maintainers to harmonise string quotes to single if they want to do so? Really sad to see that a working implementation was discarded on the basis of what seems to be personal preference of the lead maintainer. |
Black is like the original vim. It's the maintainer's project, not a community project like nvim. My humble suggestion on further friction is to always keep your preference as the default and explain why your opinion is best in the readme.md, yet allow PRs that don't affect your default as a form of extra config when it is highly desirable. |
Now there are no excuses not to use black.
Fixes #594