Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beacon-chain/rpc/service.logNewClientConnection has unsafe map access #6434

Closed
prestonvanloon opened this issue Jun 27, 2020 · 1 comment · Fixed by #6446
Closed

beacon-chain/rpc/service.logNewClientConnection has unsafe map access #6434

prestonvanloon opened this issue Jun 27, 2020 · 1 comment · Fixed by #6446
Assignees
Labels
Bug Something isn't working Priority: High High priority item
Milestone

Comments

@prestonvanloon
Copy link
Member

User reported concurrent map access panic and their logs point to these lines of code.

if !s.connectedRPCClients[clientInfo.Addr] {
log.WithFields(logrus.Fields{
"addr": clientInfo.Addr.String(),
}).Infof("New gRPC client connected to beacon node")
s.connectedRPCClients[clientInfo.Addr] = true
}

See comments here: #5576 (comment)

Assigning to @rauljordan as the original author of this log in #6233.

cc: @stefa2k

@stefa2k
Copy link

stefa2k commented Jun 30, 2020

looking good, service has been stable for 16h now without this errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Priority: High High priority item
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants