Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect block propagation information - 'number of hops' #5721

Closed
Phistr90 opened this issue May 3, 2020 · 6 comments
Closed

Collect block propagation information - 'number of hops' #5721

Phistr90 opened this issue May 3, 2020 · 6 comments
Labels
Help Wanted Extra attention is needed

Comments

@Phistr90
Copy link

Phistr90 commented May 3, 2020

🚀 Feature Request

Description

As seen in #5665 getting blocks late can lead to an increase in incorrect head voting.
In order to understand the root cause of late blocks and high propagation times better it might be helpful to get some data on how many hops were done in order to get the block from a peer.

But please note: This feature should be for debugging purposes only and should be removed for mainnet as it poses a security concern. It makes it easy to figure out the node that is associated with a certain validator.

@Phistr90 Phistr90 changed the title Collect meta data on 'number of hops' for block propagation Collect block propagation information - 'number of hops' May 3, 2020
@shayzluf shayzluf added the Help Wanted Extra attention is needed label May 4, 2020
@prestonvanloon
Copy link
Member

I don't think this is going to be possible with the current networking protocol. We don't have any mechanism to transmit additional metadata with pubsub objects as far as i know

@Phistr90
Copy link
Author

Phistr90 commented May 4, 2020

@prestonvanloon doesnt libp2p pubsub supports tracing? I might misunderstand that feature.

@rauljordan
Copy link
Contributor

rauljordan commented May 28, 2020

@raulk we would love your feedback on this. How would you recommend tracking message propagation metadata such as hops using libp2p's options?

@nisdas
Copy link
Member

nisdas commented May 28, 2020

Libp2p pubsub does support tracing, so if we do desire we can trace events. Ex:
https://github.com/libp2p/go-libp2p-pubsub/blob/master/pubsub.go#L375

@prestonvanloon
Copy link
Member

Not sure how libp2p pubsub tracing collection works, but we could track the message IDs via opencensus.

@rauljordan
Copy link
Contributor

We are closing this now that we are in mainnet. Unlikely we will develop this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants