-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect block propagation information - 'number of hops' #5721
Comments
I don't think this is going to be possible with the current networking protocol. We don't have any mechanism to transmit additional metadata with pubsub objects as far as i know |
@prestonvanloon doesnt libp2p pubsub supports tracing? I might misunderstand that feature. |
@raulk we would love your feedback on this. How would you recommend tracking message propagation metadata such as hops using libp2p's options? |
Libp2p pubsub does support tracing, so if we do desire we can trace events. Ex: |
Not sure how libp2p pubsub tracing collection works, but we could track the message IDs via opencensus. |
We are closing this now that we are in mainnet. Unlikely we will develop this feature |
🚀 Feature Request
Description
As seen in #5665 getting blocks late can lead to an increase in incorrect head voting.
In order to understand the root cause of late blocks and high propagation times better it might be helpful to get some data on how many hops were done in order to get the block from a peer.
But please note: This feature should be for debugging purposes only and should be removed for mainnet as it poses a security concern. It makes it easy to figure out the node that is associated with a certain validator.
The text was updated successfully, but these errors were encountered: