Clean Up Of Dynamic Subscriptions

[nisdas]

What type of PR is this?

Feature Improvement

What does this PR do? Why is it needed?

This PR improves subnet subscriptions for aggregators. Previously we did not subscribe
if we could not find a relevant peer. However this is resolved by subscribing to the
subnet at all times and then searching for the peer.

This also adds in a regression test for #5683 .

Which issues(s) does this PR fix?

N.A

Other notes for review

[codecov]

Codecov Report

Merging #5690 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5690   +/-   ##
=======================================
  Coverage   20.95%   20.95%           
=======================================
  Files         240      240           
  Lines       21453    21453           
=======================================
  Hits         4495     4495           
  Misses      16077    16077           
  Partials      881      881           

[shayzluf]

missing tests for subscribeAggregatorSubnet

[nisdas]

I just changed the name for subscribeAggregatorSubnet , also unit testing this is difficult because this
function touches onto discovery and I am not sure if its possible to reliably test discovery all the way from the sync package. Most of our brittle tests in p2p are discovery related.